Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vscode_settings.json typo #107800

Closed
wants to merge 1 commit into from

Conversation

spastorino
Copy link
Member

r? @jyn514

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2023
@spastorino
Copy link
Member Author

@bors rollup

@jyn514
Copy link
Member

jyn514 commented Feb 8, 2023

Not a typo, see #107547

@jyn514 jyn514 closed this Feb 8, 2023
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-13 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:ac593985615ec2ede58e132d2e21d2b1cbd6127c)
Download action repository 'rust-lang/simpleinfra@master' (SHA:cb2b9920774a63bd54b3676f2b669ea1e777a91e)
Complete job name: PR (x86_64-gnu-llvm-13, false, ubuntu-20.04-xl)
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  CI_JOB_NAME: x86_64-gnu-llvm-13
---
test setup::tests::check_matching_settings_hash ... FAILED

failures:

---- setup::tests::check_matching_settings_hash stdout ----
thread 'setup::tests::check_matching_settings_hash' panicked at 'assertion failed: `(left == right)`
  left: `"1993683aad3ecd43bea6c65e545a15035242a4ea6d207c2b607777ec05a1af4c"`,
 right: `"ea67e259dedf60d4429b6c349a564ffcd1563cf41c920a856d1f5b16b4701ac8"`: Update `SETTINGS_HASHES` with the new hash of `src/etc/vscode_settings.json`', setup/tests.rs:9:5

failures:
    setup::tests::check_matching_settings_hash

@spastorino
Copy link
Member Author

Not a typo, see #107547

Ohh good to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants