Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create symlink only for non-windows operating systems #107876

Merged
merged 1 commit into from
Feb 10, 2023
Merged

create symlink only for non-windows operating systems #107876

merged 1 commit into from
Feb 10, 2023

Conversation

zephaniahong
Copy link
Contributor

@zephaniahong zephaniahong commented Feb 10, 2023 •
edited
Loading

Follow up on #107834
It's my first time using the #cfg attribute. Did I use it correctly?

Thank you!

@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 10, 2023
@albertlarsan68
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Feb 10, 2023

📌 Commit d560574 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2023
@petrochenkov
Copy link
Contributor

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Feb 10, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2023
@bors
Auto merge of rust-lang#107889 - matthiaskrgr:rollup-c0d4al0, r=matth…
3574b1a 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#107789 (Avoid exposing type parameters and implementation details sourced from macro expansions)
 - rust-lang#107836 (Handle properly when there is no crate attrs)
 - rust-lang#107839 (avoid duplicating the RUSTC_LOG env var name)
 - rust-lang#107866 (Allow wasi-libc to initialize its environment variables lazily.)
 - rust-lang#107876 (create symlink only for non-windows operating systems)
 - rust-lang#107882 (Cleanup typos in en_US/borrowck.ftl)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 08ce17a into rust-lang:master Feb 10, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 10, 2023
@zephaniahong zephaniahong deleted the issue-107547-fix branch February 11, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zephaniahong @rustbot @albertlarsan68 @bors @petrochenkov