Avoid accessing HIR when it can be avoided

[cjgillot]

Experiment to see if it helps some incremental cases.

Will be rebased once #107942 gets merged.

r? @ghost

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit ed22fee8092fbd056a4789e14370c33082cee27e with merge fd8d54b2810cc063475a4e9a3caa67818ced6f8e...

[bors]

☀️ Try build successful - checks-actions
Build commit: fd8d54b2810cc063475a4e9a3caa67818ced6f8e (fd8d54b2810cc063475a4e9a3caa67818ced6f8e)

[rust-timer]

Finished benchmarking commit (fd8d54b2810cc063475a4e9a3caa67818ced6f8e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.4%	[1.4%, 1.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in need_type_info.rs

cc @lcnr

[cjgillot]

r? compiler

[oli-obk]

r=me with CI happy

[oli-obk]

@bors r+

[bors]

📌 Commit 065f0b2 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 065f0b2 with merge 377a18426ae710eb2a7e740fa7eb461fdff6e538...

[bors]

💔 Test failed - checks-actions

[cjgillot]

@bors retry curl: (22) The requested URL returned error: 404

[bors]

⌛ Testing commit 065f0b2 with merge 2d14db3...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 2d14db3 to master...

[rust-timer]

Finished benchmarking commit (2d14db3): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	3
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

[rust-log-analyzer]

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

curl: (22) The requested URL returned error: 404

error: failed to download llvm from ci

    help: old builds get deleted after a certain time
    help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml:

    [llvm]
    download-ci-llvm = false
Build completed unsuccessfully in 0:00:00