Fix index out of bounds ICE in point_at_expr_source_of_inferred_type
#108050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There might be more type params than args to a method call, which leads to an index out of bounds panic.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
This needs a UI test |
martingms
commented
Feb 15, 2023
martingms
force-pushed
the
issue-108042-fix
branch
from
0be5394
to
d8fadfb
Compare
martingms
commented
Feb 15, 2023
martingms
force-pushed
the
issue-108042-fix
branch
from
d8fadfb
to
e159c1e
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#106372 (Use id-based thread parking on SOLID) - rust-lang#108050 (Fix index out of bounds ICE in `point_at_expr_source_of_inferred_type`) - rust-lang#108084 (Constify `RangeBounds`, `RangeX::contains` and `RangeX::is_empty` (where applicable).) - rust-lang#108101 (don't clone types that are copy) - rust-lang#108102 (simplify some refs) - rust-lang#108103 (be nice and don't slice) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
added
the
beta-nominated
rustbot
added
the
beta-accepted
cuviper
removed
the
beta-nominated
rustbot
removed
the
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be more type params than args to a method call, which leads to an index out of bounds panic.
I'm not familiar with this code at all, so unsure whether this is the right fix, but at least this patch fixes #108042 for me (I hit the same issue with similar code)