Reduce some function calls in the query system

[Zoxc]

This reduces size of rustc_driver by 0.54% and seems to be a minor performance improvement.

Benchmark	Before	After
	Time	Time	%
🟣 clap:check	1.8112s	1.8054s	-0.32%
🟣 hyper:check	0.2649s	0.2653s	0.14%
🟣 regex:check	1.0065s	1.0048s	-0.17%
🟣 syn:check	1.6226s	1.6235s	0.05%
🟣 syntex_syntax:check	6.3298s	6.3087s	-0.33%
Total	11.0351s	11.0077s	-0.25%
Summary	1.0000s	0.9987s	-0.13%

r? @cjgillot

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 94146553887d8ff47a239c0a32a33d250ba401ee with merge ef23c542de4fffd170497d3e0790d2659ca1e397...

[bors]

☀️ Try build successful - checks-actions
Build commit: ef23c542de4fffd170497d3e0790d2659ca1e397 (ef23c542de4fffd170497d3e0790d2659ca1e397)

[bors]

☀️ Try build successful - checks-actions
Build commit: ef23c542de4fffd170497d3e0790d2659ca1e397 (ef23c542de4fffd170497d3e0790d2659ca1e397)

[rust-timer]

Finished benchmarking commit (ef23c542de4fffd170497d3e0790d2659ca1e397): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 1.0%]	86
Regressions ❌ (secondary)	0.5%	[0.2%, 0.8%]	20
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.2%, 1.0%]	86

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.4%	[-3.4%, -1.5%]	2
Improvements ✅ (secondary)	-1.9%	[-3.2%, -0.4%]	3
All ❌✅ (primary)	-2.4%	[-3.4%, -1.5%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 1a55493d23268517b187eb3901f0dd3848652631 with merge 404d2ff9b632c36f5dd5a5db67d0efbce0afe3da...

[bors]

☀️ Try build successful - checks-actions
Build commit: 404d2ff9b632c36f5dd5a5db67d0efbce0afe3da (404d2ff9b632c36f5dd5a5db67d0efbce0afe3da)

[rust-timer]

Finished benchmarking commit (404d2ff9b632c36f5dd5a5db67d0efbce0afe3da): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

[Zoxc]

This could use another perf run now that the bootstrap timings is supposedly back.

[lqd]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 1a55493d23268517b187eb3901f0dd3848652631 with merge c48567d7f1a8a637f4dc84ae478d9e14ec5f53c6...

[bors]

☀️ Try build successful - checks-actions
Build commit: c48567d7f1a8a637f4dc84ae478d9e14ec5f53c6 (c48567d7f1a8a637f4dc84ae478d9e14ec5f53c6)

[rust-timer]

Finished benchmarking commit (c48567d7f1a8a637f4dc84ae478d9e14ec5f53c6): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 1.3%]	12
Regressions ❌ (secondary)	1.4%	[0.3%, 2.6%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	3
All ❌✅ (primary)	0.5%	[0.2%, 1.3%]	12

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[3.2%, 3.2%]	1
Regressions ❌ (secondary)	3.4%	[2.7%, 4.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.2%	[3.2%, 3.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.