Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give proper error message when tcx wasn't passed to decoder #109013

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Give proper error message when tcx wasn't passed to decoder #109013

merged 1 commit into from
Mar 12, 2023

Conversation

Noratrieb
Copy link
Member

I hit this yesterday and found it very confusing, even though the solution to the problem is very simple.

@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 11, 2023
@Noratrieb
Copy link
Member Author

The tcx code only displayed a custom message when debug assertions were enabled - let's see whether I have to do this too (which would be fine)

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 11, 2023
@bors
Copy link
Contributor

bors commented Mar 11, 2023

⌛ Trying commit b7a7077 with merge b065910b60ab94034f8098723fdf151532bdd13d...

@bors
Copy link
Contributor

bors commented Mar 11, 2023

☀️ Try build successful - checks-actions
Build commit: b065910b60ab94034f8098723fdf151532bdd13d (b065910b60ab94034f8098723fdf151532bdd13d)

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 11, 2023

☀️ Try build successful - checks-actions
Build commit: b065910b60ab94034f8098723fdf151532bdd13d (b065910b60ab94034f8098723fdf151532bdd13d)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b065910b60ab94034f8098723fdf151532bdd13d): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 11, 2023
@fee1-dead
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 11, 2023

📌 Commit b7a7077 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2023
@Noratrieb
Copy link
Member Author

@bors rollup=maybe perf was neutral

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 12, 2023
@matthiaskrgr
Rollup merge of rust-lang#109013 - Nilstrieb:obscurity-is-not-a-neces…
76f239a 
…sity, r=fee1-dead

Give proper error message when tcx wasn't passed to decoder

I hit this yesterday and found it very confusing, even though the solution to the problem is very simple.
This was referenced Mar 12, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2023
@bors
Auto merge of rust-lang#109043 - matthiaskrgr:rollup-genkz0e, r=matth…
24c0b81 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#108726 (tidy: enforce comment blocks to have an even number of backticks)
 - rust-lang#108797 (Allow binary files to go through the `FileLoader`)
 - rust-lang#108841 (Add suggestion to diagnostic when user has array but trait wants slice. (rebased))
 - rust-lang#108984 (bootstrap: document tidy)
 - rust-lang#109013 (Give proper error message when tcx wasn't passed to decoder)
 - rust-lang#109017 (remove duplicated calls to sort_string)
 - rust-lang#109018 (Expand on the allocator comment in `rustc-main`)
 - rust-lang#109028 (Add eslint checks for rustdoc-js tester)
 - rust-lang#109034 (Commit some tests for the new solver + lazy norm)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 738c4bf into rust-lang:master Mar 12, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 12, 2023
@Noratrieb Noratrieb deleted the obscurity-is-not-a-necessity branch March 12, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Noratrieb @rustbot @rust-timer @bors @fee1-dead @wesleywiser