do not panic on failure to acquire jobserver token #109694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r? compiler |
|
r? @Zoxc |
|
Failed to set assignee to
|
|
r? @bjorn3 |
What @belovdv is trying to say is that it's a build environment configuration issue, not an internal compiler error. |
|
This change seems fine, but the parallel compiler does also rely a bit on this operation to succeed. An incorrect |
bjorn3
reviewed
Mar 28, 2023
belovdv
force-pushed
the
fix-panic-jobserver-token
branch
from
6a4c830
to
e1fdb21
Compare
bjorn3
reviewed
Mar 28, 2023
belovdv
force-pushed
the
fix-panic-jobserver-token
branch
from
e1fdb21
to
be6a09f
Compare
|
r=me when CI passes |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 29, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#109149 (Improve error message when writer is forgotten in write and writeln macro) - rust-lang#109367 (Streamline fast rejection) - rust-lang#109548 (AnnotationColumn struct to fix hard tab column numbers in errors) - rust-lang#109694 (do not panic on failure to acquire jobserver token) - rust-lang#109705 (new solver: check for intercrate mode when accessing the cache) - rust-lang#109708 (Specialization involving RPITITs is broken so ignore the diagnostic differences) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: remove
panic.Rust fails to acquire token if an error in build system occurs - environment variable contains incorrect
jobserver-auth. It isn't ice so compiler shouldn't panic on such error.Related issue: #46981