Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce core counts for a number of builders #110142

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

Mark-Simulacrum
Copy link
Member

Best reviewed by-commit; first commit renames all builder names to include core counts.

Applied changes for these builders (only on the auto branch, haven't touched PR CI):

  • arm-android -> 8 core (currently at 39 minutes; 25.58% CPU)
  • armhf-gnu -> 8 core (currently at 31 minutes; 30.97% CPU)
  • dist-aarch64-linux -> 8 core (currently at 35 minutes; 55.38% CPU)
  • dist-android -> 8 core (currently at 18 minutes; 43.03% CPU)
  • dist-armhf-linux -> 8 core (currently at 27 minutes; 54.71% CPU)
  • dist-armv7-linux -> 8 core (currently at 29 minutes; 50.33% CPU)
  • dist-i586-gnu-i586-i686-musl -> 8 core (currently at 27 minutes; 48.31% CPU)
  • dist-i686-linux -> 8 core (currently at 32 minutes; 52.39% CPU)
  • dist-mips-linux -> 8 core (currently at 25 minutes; 55.09% CPU)
  • dist-mips64-linux -> 8 core (currently at 25 minutes; 55.33% CPU)
  • dist-mips64el-linux -> 8 core (currently at 26 minutes; 54.93% CPU)
  • dist-mipsel-linux -> 8 core (currently at 25 minutes; 55.38% CPU)
  • dist-powerpc-linux -> 8 core (currently at 26 minutes; 55.77% CPU)
  • dist-powerpc64-linux -> 8 core (currently at 27 minutes; 55.03% CPU)
  • dist-powerpc64le-linux -> 8 core (currently at 27 minutes; 54.95% CPU)
  • dist-riscv64-linux -> 8 core (currently at 26 minutes; 54.43% CPU)
  • dist-s390x-linux -> 8 core (currently at 30 minutes; 55.97% CPU)
  • dist-various-1 -> 8 core (currently at 36 minutes; 29.16% CPU)
  • dist-various-2 -> 8 core (currently at 27 minutes; 32.69% CPU)
  • dist-x86_64-freebsd -> 8 core (currently at 27 minutes; 51.69% CPU)
  • dist-x86_64-illumos -> 8 core (currently at 30 minutes; 54.88% CPU)
  • dist-x86_64-musl -> 8 core (currently at 39 minutes; 57.56% CPU)
  • dist-x86_64-netbsd -> 8 core (currently at 26 minutes; 55.82% CPU)
  • mingw-check -> 8 core (currently at 17 minutes; 35.00% CPU)
  • test-various -> 8 core (currently at 22 minutes; 44.84% CPU)
  • wasm32 -> 8 core (currently at 19 minutes; 62.94% CPU)
  • x86_64-gnu -> 8 core (currently at 32 minutes; 50.31% CPU)
  • x86_64-gnu-stable -> 8 core (currently at 32 minutes; 51.23% CPU)
  • x86_64-gnu-aux -> 8 core (currently at 22 minutes; 46.39% CPU)
  • x86_64-gnu-debug -> 8 core (currently at 21 minutes; 53.93% CPU)
  • x86_64-gnu-distcheck -> 8 core (currently at 38 minutes; 55.93% CPU)
  • x86_64-gnu-llvm-15 -> 8 core (currently at 34 minutes; 52.99% CPU)
  • x86_64-gnu-llvm-14 -> 8 core (currently at 34 minutes; 52.09% CPU)
  • x86_64-gnu-llvm-14-stage1 -> 8 core (currently at 33 minutes; 51.13% CPU)
  • x86_64-gnu-nopt -> 8 core (currently at 29 minutes; 53.36% CPU)
  • x86_64-gnu-tools -> 8 core (currently at 22 minutes; 40.56% CPU)

We may also want to look at merging some of these builders in the future (to deduplicate stage0 builds and such) but that can happen separately - and is more work than just adjusting core counts.

r? @pietroalbini

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 10, 2023
This will allow moving jobs between 8 and 16 core VMs in the next commit
more easily.
These builders aren't particularly high on overall average CPU usage and finish in typically around
30 minutes. Cutting their core counts will hopefully not significantly increase wall-time while
cutting costs, allowing us to shift some of the wins into our slower builders.
@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 10, 2023

📌 Commit 3153eaa has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 11, 2023
…, r=pietroalbini

Reduce core counts for a number of builders

Best reviewed by-commit; first commit renames all builder names to include core counts.

Applied changes for these builders (only on the auto branch, haven't touched PR CI):

- arm-android -> 8 core (currently at 39 minutes; 25.58% CPU)
- armhf-gnu -> 8 core (currently at 31 minutes; 30.97% CPU)
- dist-aarch64-linux -> 8 core (currently at 35 minutes; 55.38% CPU)
- dist-android -> 8 core (currently at 18 minutes; 43.03% CPU)
- dist-armhf-linux -> 8 core (currently at 27 minutes; 54.71% CPU)
- dist-armv7-linux -> 8 core (currently at 29 minutes; 50.33% CPU)
- dist-i586-gnu-i586-i686-musl -> 8 core (currently at 27 minutes; 48.31% CPU)
- dist-i686-linux -> 8 core (currently at 32 minutes; 52.39% CPU)
- dist-mips-linux -> 8 core (currently at 25 minutes; 55.09% CPU)
- dist-mips64-linux -> 8 core (currently at 25 minutes; 55.33% CPU)
- dist-mips64el-linux -> 8 core (currently at 26 minutes; 54.93% CPU)
- dist-mipsel-linux -> 8 core (currently at 25 minutes; 55.38% CPU)
- dist-powerpc-linux -> 8 core (currently at 26 minutes; 55.77% CPU)
- dist-powerpc64-linux -> 8 core (currently at 27 minutes; 55.03% CPU)
- dist-powerpc64le-linux -> 8 core (currently at 27 minutes; 54.95% CPU)
- dist-riscv64-linux -> 8 core (currently at 26 minutes; 54.43% CPU)
- dist-s390x-linux -> 8 core (currently at 30 minutes; 55.97% CPU)
- dist-various-1 -> 8 core (currently at 36 minutes; 29.16% CPU)
- dist-various-2 -> 8 core (currently at 27 minutes; 32.69% CPU)
- dist-x86_64-freebsd -> 8 core (currently at 27 minutes; 51.69% CPU)
- dist-x86_64-illumos -> 8 core (currently at 30 minutes; 54.88% CPU)
- dist-x86_64-musl -> 8 core (currently at 39 minutes; 57.56% CPU)
- dist-x86_64-netbsd -> 8 core (currently at 26 minutes; 55.82% CPU)
- mingw-check -> 8 core (currently at 17 minutes; 35.00% CPU)
- test-various -> 8 core (currently at 22 minutes; 44.84% CPU)
- wasm32 -> 8 core (currently at 19 minutes; 62.94% CPU)
- x86_64-gnu -> 8 core (currently at 32 minutes; 50.31% CPU)
- x86_64-gnu-stable -> 8 core (currently at 32 minutes; 51.23% CPU)
- x86_64-gnu-aux -> 8 core (currently at 22 minutes; 46.39% CPU)
- x86_64-gnu-debug -> 8 core (currently at 21 minutes; 53.93% CPU)
- x86_64-gnu-distcheck -> 8 core (currently at 38 minutes; 55.93% CPU)
- x86_64-gnu-llvm-15 -> 8 core (currently at 34 minutes; 52.99% CPU)
- x86_64-gnu-llvm-14 -> 8 core (currently at 34 minutes; 52.09% CPU)
- x86_64-gnu-llvm-14-stage1 -> 8 core (currently at 33 minutes; 51.13% CPU)
- x86_64-gnu-nopt -> 8 core (currently at 29 minutes; 53.36% CPU)
- x86_64-gnu-tools -> 8 core (currently at 22 minutes; 40.56% CPU)

We may also want to look at merging some of these builders in the future (to deduplicate stage0 builds and such) but that can happen separately - and is more work than just adjusting core counts.

r? `@pietroalbini`
@bors
Copy link
Contributor

bors commented Apr 15, 2023

⌛ Testing commit 3153eaa with merge fef27e0...

@bors
Copy link
Contributor

bors commented Apr 15, 2023

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing fef27e0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 15, 2023
@bors bors merged commit fef27e0 into rust-lang:master Apr 15, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 15, 2023
@Mark-Simulacrum Mark-Simulacrum deleted the reduce-core-counts branch April 15, 2023 11:52
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fef27e0): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.2% [2.3%, 4.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants