Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #111153

Merged
merged 31 commits into from
May 3, 2023
Merged

Rollup of 11 pull requests #111153

merged 31 commits into from
May 3, 2023

Commits on Apr 17, 2023

  1. Configuration menu
    Copy the full SHA
    e40a446 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Configuration menu
    Copy the full SHA
    20742ea View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Configuration menu
    Copy the full SHA
    25e9b79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6fcf165 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Change rlink serialization from MemEncoder to FileEncoder.

    Because we're writing to a file, so `FileEncoder` is better because we
    don't have to write all the data to memory first.
    nnethercote committed May 1, 2023
    Configuration menu
    Copy the full SHA
    b4ba2f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0453cda View commit details
    Browse the repository at this point in the history
  3. remove pointless FIXME in bootstrap::download

    The suggestion given by `FIXME` to use `CompilerMetadata` for
    `download_toolchain` in `bootstrap::download` can result in more
    confusion. This is because `stamp_key` is not always a date; it
    can also be a commit hash. Additionally, unlike in `download_beta_toolchain`,
    in the `download_ci_rustc` function, `version` and `commit` values
    are calculated separately.
    
    Signed-off-by: ozkanonur <work@onurozkan.dev>
    onur-ozkan committed May 1, 2023
    Configuration menu
    Copy the full SHA
    bc68de9 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Move some Encodable/Decodable tests.

    Round-trip encoding/decoding of many types is tested in
    `compiler/rustc_serialize/tests/opaque.rs`. There is also a small amount
    of encoding/decoding testing in three files in `tests/ui-fulldeps`.
    
    There is no obvious reason why these three files are necessary. They
    were originally added in 2014. Maybe it wasn't possible for a proc
    macro to run in a unit test back then?
    
    This commit just moves the testing from those three files into the unit
    test.
    nnethercote committed May 2, 2023
    Configuration menu
    Copy the full SHA
    8d359e4 View commit details
    Browse the repository at this point in the history
  2. Remove MemEncoder.

    It's only used in tests. Which is bad, because it means that
    `FileEncoder` is used in the compiler but isn't used in tests!
    
    `tests/opaque.rs` now tests encoding/decoding round-trips via file.
    Because this is slower than memory, this commit also adjusts the
    `u16`/`i16` tests so they are more like the `u32`/`i32` tests, i.e. they
    don't test every possible value.
    nnethercote committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ebee3f8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef77dd2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7bc6d59 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6af761a View commit details
    Browse the repository at this point in the history
  6. Amend the triagebot comment for Cargo.lock changes.

    I don't like the current wording. It's obnoxious to be told by a bot
    that a change I made intentionally is "probably unintentional"! I also
    don't like describing unintentional changes as "Random", it's not the
    right word.
    nnethercote committed May 2, 2023
    1 Configuration menu
    Copy the full SHA
    51b9f78 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6e01e91 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    86f50b9 View commit details
    Browse the repository at this point in the history
  9. Make tools happy

    compiler-errors committed May 2, 2023
    Configuration menu
    Copy the full SHA
    40a63cb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    03469c3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6fca051 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Correctly convert an NT path to a Win32 path

    This can be done by simply changing the `\??\` prefix to `\\?\` and then attempting to convert to a user path.
    
    Currently it simply strips off the prefix which could lead to the wrong path being returned (e.g. if it's not a drive path or if the path contains trailing spaces, etc).
    ChrisDenton committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6e37784 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    109a47f View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#107978 - ChrisDenton:nt-to-win32, r=m-ou-se

    Correctly convert an NT path to a Win32 path in `read_link`
    
    This can be done by simply changing the `\??\` prefix to `\\?\`.
    
    Currently it strips off the prefix which could lead to the wrong path being returned (e.g. if it's not a drive path or if the path contains trailing spaces, etc).
    
    r? libs
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    068807a View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#110436 - Mark-Simulacrum:support-xz-version…

    …, r=pietroalbini
    
    Support loading version information from xz tarballs
    
    This is intended to allow us to move recompression from xz (produced in CI) to gz after an initial manifest run, which produces a list of actually required artifacts. The rest are then deleted, which means that we can avoid recompressing them, saving a bunch of time.
    
    This is essentially untested and more might be needed, will run a patched promote-release against try artifacts from this PR. If we do go ahead with this we'll either need to backport this patch to beta/stable, wait for it to propagate, or temporarily recompress to gzip but not xz tarballs (or similar).
    
    r? `@pietroalbini`
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    32f3ddb View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#110791 - compiler-errors:negative-bounds, r…

    …=oli-obk
    
    Implement negative bounds for internal testing purposes
    
    Implements partial support the `!` negative polarity on trait bounds. This is incomplete, but should allow us to at least be able to play with the feature.
    
    Not even gonna consider them as a public-facing feature, but I'm implementing them because would've been nice to have in UI tests, for example in rust-lang#110671.
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    80df4ab View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#110874 - compiler-errors:index-op-specific,…

    … r=oli-obk
    
    Adjust obligation cause code for `find_and_report_unsatisfied_index_impl`
    
    Makes the error message a bit easier to read.
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    a2e4dab View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#110908 - petrochenkov:notagain4, r=compiler…

    …-errors
    
    resolve: One more attempt to simplify `module_children`
    
    If the next step is performed and `fn module_children_local` is merged with the `module_children` query, then it causes perf regressions, regardless of whether query result feeding is [used](https://perf.rust-lang.org/compare.html?start=43a78029b4f4d92978b8fde0a677ea300b113c41&end=2eb5bcc5068b9d92f74bcb1797da664865d6981d&stat=instructions:u) or [not](https://perf.rust-lang.org/compare.html?start=2fce2290865f012391b8f3e581c3852a248031fa&end=2a33d6cd99481d1712037a79e7d66a8aefadbf72&stat=instructions:u).
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    0228994 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#110943 - RalfJung:interpret-unsized-arg-ice…

    …, r=oli-obk
    
    interpret: fail more gracefully on uninit unsized locals
    
    r? `@oli-obk`
    
    Fixes rust-lang#68538
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    8b7080b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#111062 - clubby789:invalid-repr-unchecked, …

    …r=petrochenkov
    
    Don't bail out early when checking invalid `repr` attr
    
    Fixes rust-lang#111051
    
    An invalid repr delays a bug. If there are other invalid attributes on the item, we emit a warning and exit without re-checking the repr here, so no error is emitted and the delayed bug ICEs
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    fce0741 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#111069 - ozkanonur:remove-pointless-fixme, …

    …r=albertlarsan68
    
    remove pointless `FIXME` in `bootstrap::download`
    
    The suggestion given by `FIXME` to use `CompilerMetadata` for `download_toolchain` in `bootstrap::download` can result in more confusion. This is because `stamp_key` is not always a date; it can also be a commit hash. Additionally, unlike in `download_beta_toolchain`, in the `download_ci_rustc` function, `version` and `commit` values are calculated separately.
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    a47fa34 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#111086 - nnethercote:rm-MemEncoder, r=cjgillot

    Remove `MemEncoder`
    
    `MemEncoder` only has one non-test use, and `FileEncoder` would be more appropriate there anyway.
    
    r? ``@cjgillot``
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    887dffc View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#111097 - oli-obk:🚲_layout, r=compiler-errors

    Avoid ICEing miri on layout query cycles
    
    Miri has special logic for catching panics during interpretation. Raising a fatal error in rustc uses unwinding to abort compilation. Thus miri ends up catching that fatal error and thinks it saw an ICE. While we should probably change that to ignore `Fatal` payloads, I think it's also neat to continue compilation after a layout query cycle 😆
    
    Query cycles now (in addition to reporting an error just like before), return `Err(Cycle)` instead of raising a fatal error. This allows the interpreter to wind down via the regular error paths.
    
    r? `@RalfJung` for a first round, feel free to reroll for the compiler team once the miri side looks good
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    e87fcf9 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#111112 - nnethercote:triagebot, r=compiler-…

    …errors
    
    Add some triagebot notifications for nnethercote.
    
    r? ````@compiler-errors````
    Dylan-DPC authored May 3, 2023
    Configuration menu
    Copy the full SHA
    b5bbe68 View commit details
    Browse the repository at this point in the history