Appease lints #111569
Merged
Appease lints #111569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A warning about an unnecessary drop used to appear when running the linkchecker. Also some clippy warnings
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 15, 2023
Appease lints Resolved an unnecessary drop warning that appeared when running the linkchecker. Some clippy warnings, too. Edit: Well this fired up all the CI pipeline. I hope that's not a problem.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#102673 (Update doc for `PhantomData` to match code example) - rust-lang#111531 (Fix ice caused by shorthand fields in NoFieldsForFnCall) - rust-lang#111547 (Start node has no immediate dominator) - rust-lang#111548 (add util function to TokenStream to eliminate some clones) - rust-lang#111560 (Simplify find_width_of_character_at_span.) - rust-lang#111569 (Appease lints) - rust-lang#111581 (Fix some misleading and copy-pasted `Pattern` examples) - rust-lang#111582 ((docs) Change "wanting" to "want") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved an unnecessary drop warning that appeared when running the linkchecker. Some clippy warnings, too.
Edit: Well this fired up all the CI pipeline. I hope that's not a problem.