bootstrap: check for dry run when copying env vars for msvc #112722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @clubby789 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 17, 2023
bootstrap: check for dry run when copying env vars for msvc The new synthetic targets for mir-opt blessing aren't added to `builder.cc` during dry runs, causing `x.py test tests/mir-opt --bless` to crash on MSVC when it tries to copy env vars to the C compiler invocation. This PR adds a check for dry run to fix the panic.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 18, 2023
bootstrap: check for dry run when copying env vars for msvc The new synthetic targets for mir-opt blessing aren't added to `builder.cc` during dry runs, causing `x.py test tests/mir-opt --bless` to crash on MSVC when it tries to copy env vars to the C compiler invocation. This PR adds a check for dry run to fix the panic.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 18, 2023
bootstrap: check for dry run when copying env vars for msvc The new synthetic targets for mir-opt blessing aren't added to `builder.cc` during dry runs, causing `x.py test tests/mir-opt --bless` to crash on MSVC when it tries to copy env vars to the C compiler invocation. This PR adds a check for dry run to fix the panic.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 18, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#107200 (io: soften ‘at most one write attempt’ requirement in io::Write::write) - rust-lang#112667 (Move WF/ConstEvaluatable goal to clause) - rust-lang#112685 (std: only depend on dlmalloc for wasm*-unknown) - rust-lang#112722 (bootstrap: check for dry run when copying env vars for msvc) - rust-lang#112734 (Make `Bound::predicates` use `Clause`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new synthetic targets for mir-opt blessing aren't added to
builder.ccduring dry runs, causingx.py test tests/mir-opt --blessto crash on MSVC when it tries to copy env vars to the C compiler invocation. This PR adds a check for dry run to fix the panic.