Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we are migrating to askama #113115

Merged
merged 2 commits into from
Aug 16, 2023
Merged

we are migrating to askama #113115

merged 2 commits into from
Aug 16, 2023

Conversation

tshepang
Copy link
Member

see #108868

@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2023

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 28, 2023
@tshepang @bugadani
accept review suggestion
545cd1b 
Co-authored-by: Dániel Buga <bugadani@gmail.com>
@tshepang
Copy link
Member Author

'tis ready

@est31
Copy link
Member

est31 commented Aug 16, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 16, 2023

📌 Commit 545cd1b has been approved by est31

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 16, 2023
@GuillaumeGomez
Rollup merge of rust-lang#113115 - tshepang:patch-5, r=est31
5993f9f 
we are migrating to askama

see rust-lang#108868
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 16, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 16, 2023
@matthiaskrgr
Rollup merge of rust-lang#113115 - tshepang:patch-5, r=est31
374fba7 
we are migrating to askama

see rust-lang#108868
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 16, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2023
@bors
Auto merge of rust-lang#114905 - matthiaskrgr:rollup-uxhhr7p, r=matth…
27fb598 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#113115 (we are migrating to askama)
 - rust-lang#114784 (Improve `invalid_reference_casting` lint)
 - rust-lang#114822 (Improve code readability by moving fmt args directly into the string)
 - rust-lang#114878 (rustc book: make more pleasant to search)
 - rust-lang#114899 (Add missing Clone/Debug impls to SMIR Trait related tys)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 52d6947 into rust-lang:master Aug 16, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 16, 2023
@tshepang tshepang deleted the patch-5 branch August 17, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugadani bugadani bugadani left review comments

@est31 est31 est31 approved these changes

Assignees

@jsha jsha

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tshepang @rustbot @est31 @bors @bugadani @jsha