Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #113420

Closed
wants to merge 14 commits into from

Commits on May 24, 2023

  1. Configuration menu
    Copy the full SHA
    cdaef2c View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Configuration menu
    Copy the full SHA
    5488a64 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Configuration menu
    Copy the full SHA
    8725c5d View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Add a regression test for rust-lang#109054

    Signed-off-by: Yuki Okushi <jtitor@2k36.org>
    JohnTitor committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    86728e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Configuration menu
    Copy the full SHA
    3acaa56 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eab0071 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    545ce3e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3247275 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#111917 - WaffleLapkin:validate_unalloc, r=o…

    …li-obk
    
    Simplify duplicate checks for mir validator
    
    This removes unnecessary allocations & is less code.
    matthiaskrgr authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    f88151c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#112008 - intruder-kat:master, r=Nilstrieb

    Fix incorrect documented default bufsize in bufreader/writer
    matthiaskrgr authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    45861e2 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#112825 - compiler-errors:tait-defining-cycl…

    …e, r=lcnr
    
    Don't call `type_of` on TAIT in defining scope in new solver
    
    It's *never* productive to call `consider_auto_trait_candidate` on a TAIT in the defining scope, since it will always lead to a query cycle since we call `type_of` on the TAIT. So let's just don't.
    
    I've reserved this behavior just to `SolverMode::Normal` just to avoid any future problems, since this is *technically* incomplete since we're discarding a candidate that could *theoretically* apply. But given such candidate assembly *always* leads to a query cycle, I think it's relatively low risk, and I could be convinced otherwise and make this apply to both solver mode. I assume it's far less likely to be encountered in coherence, though.
    
    This is much more likely to encounter in the new solver, though it can also be encountered in the old solver too, so I'm happy to discuss whether this new behavior we even want in the first place...
    
    I encountered this in a couple of failing UI tests:
    * `tests/ui/type-alias-impl-trait/issue-62000-associate-impl-trait-lifetimes.rs`
    * `tests/ui/type-alias-impl-trait/issue-93411.rs`
    
    r? `@lcnr`
    matthiaskrgr authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    8724995 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#113164 - JohnTitor:issue-109054, r=compiler…

    …-errors
    
    Add a regression test for rust-lang#109054
    
    Closes rust-lang#109054
    r? `@compiler-errors`
    matthiaskrgr authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    f1418ea View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#113335 - compiler-errors:reveal-opaques-in-…

    …new-solver, r=lcnr
    
    Reveal opaques in new solver
    
    We were testing against the wrong reveal mode 😨
    
    Also a couple of misc commits that I don't want to really put in separate prs
    
    r? `@lcnr`
    matthiaskrgr authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    172620c View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#113397 - compiler-errors:new-select-prefer-…

    …obj, r=lcnr
    
    Prefer object candidates in new selection
    
    `dyn Any` shouldn't be using [this implementation](https://doc.rust-lang.org/std/any/trait.Any.html#impl-Any-for-T) during codegen.
    
    Prefer object candidates over other candidates, except for other object candidates.
    matthiaskrgr authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    d139578 View commit details
    Browse the repository at this point in the history