-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use constants from object crate #113595
Use constants from object crate #113595
Conversation
Replace hard-coded values with GNU_PROPERTY_{X86|AARCH64}_FEATURE_1_AND from the object crate.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @WaffleLapkin (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Oh, thanks! @bors r+ rollup |
Use constants from object crate Replace hard-coded values with `GNU_PROPERTY_{X86|AARCH64}_FEATURE_1_AND` from the object crate. When working on [issue](rust-lang#103001) it was suggested that we moved these constants to the object crate . [PR](gimli-rs/object#537). Now that that the object crate has been updated [PR](rust-lang#111413) we can make this change.
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#113373 (various download-rustc fixes) - rust-lang#113385 (style-guide: Fix chain example to match rustfmt behavior) - rust-lang#113567 (While let suggestion will work for closure body) - rust-lang#113579 (Revert "fix: 🐛 etc/bash_complettion -> src/etc/... to avoid copy …) - rust-lang#113595 (Use constants from object crate) r? `@ghost` `@rustbot` modify labels: rollup
Replace hard-coded values with
GNU_PROPERTY_{X86|AARCH64}_FEATURE_1_AND
from the object crate.When working on issue it was suggested that we moved these constants to the object crate . PR. Now that that the object crate has been updated PR we can make this change.