open pidfd in child process and send to the parent via SOCK_SEQPACKET+CMSG #113939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
ping @Mark-Simulacrum |
Mark-Simulacrum
added
S-waiting-on-author
| msg.msg_controllen = mem::size_of::<Cmsg>() as _; | ||
| msg.msg_control = &mut cmsg as *mut _ as *mut _; | ||
|
|
||
| match cvt_r(|| libc::recvmsg(sock.as_raw(), &mut msg, 0)) { |
There was a problem hiding this comment.
Do we need a timeout here (or something like it) at all? E.g., if we're unlucky and the child process is kill'd by something before we get the pidfd sent back? Or will that close the stream and end here?
My sense is that we should be ok, but wanted to raise in case I overlooked something.
There was a problem hiding this comment.
The parent closes its output, so only the child holds the remote side of the socket open. If the child gets killed that gets closed, which disconnects the socket which in turn leads to a 0-length read in the parent and a return from this function.
the8472
force-pushed
the
pidfd-from-child
branch
from
78ea4c1
to
4673247
Compare
|
@bors r=Mark-Simulacrum |
|
📌 Commit 4673247bf49c260e952082d463fb74342aa81434 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 4673247bf49c260e952082d463fb74342aa81434 with merge 829cf9a30cfb622ec07dbad9fddeffdae487b630... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
…+CMSG This is a 100% race-free way to obtain a child's pidfd while avoiding `clone3`.
the8472
force-pushed
the
pidfd-from-child
branch
from
4673247
to
8d349c1
Compare
|
fixed cfg on the test @bors r=Mark-Simulacrum |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#113939 (open pidfd in child process and send to the parent via SOCK_SEQPACKET+CMSG) - rust-lang#114548 (Migrate a trait selection error to use diagnostic translation) - rust-lang#114606 (fix: not insert missing lifetime for `ConstParamTy`) - rust-lang#114634 (Mention riscv64-linux-android support in Android documentation) - rust-lang#114638 (Remove old RPITIT tests (revisions were removed)) - rust-lang#114641 (Rename copying `ascii::Char` methods from `as_` to `to_`) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 25, 2024
…ochenkov Clean up after clone3 removal from pidfd code (docs and tests) rust-lang#113939 removed clone3 from pidfd code. This patchset does necessary clean up: fixes docs and tests
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 25, 2024
…ochenkov Clean up after clone3 removal from pidfd code (docs and tests) rust-lang#113939 removed clone3 from pidfd code. This patchset does necessary clean up: fixes docs and tests
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2024
Rollup merge of rust-lang#120306 - safinaskar:clone3-clean-up, r=petrochenkov Clean up after clone3 removal from pidfd code (docs and tests) rust-lang#113939 removed clone3 from pidfd code. This patchset does necessary clean up: fixes docs and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids using
clone3when a pidfd is requested while still getting it in a 100% race-free manner by passing it up from the child process.This should solve most concerns in #82971