[rustdoc] Remove unneeded clone() calls for derive_id

[GuillaumeGomez]

I realized we were cloning values before passing them to derive_id where they are cloned again, which isn't great. Since they'll be cloned anyway, let's allow to pass both by reference and by value.

r? @notriddle

[GuillaumeGomez]

I'm not sure it'll impact performance but better confirm:

@bors try @rust-timer queue

[bors]

⌛ Trying commit f65dc084ceb7f562668ea249391b138d1303dfe6 with merge 5234c646c74d83bfccd3f219d68d867dd0b877f8...

[bors]

☀️ Try build successful - checks-actions
Build commit: 5234c646c74d83bfccd3f219d68d867dd0b877f8 (5234c646c74d83bfccd3f219d68d867dd0b877f8)

[rust-timer]

Finished benchmarking commit (5234c646c74d83bfccd3f219d68d867dd0b877f8): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 653.409s -> 652.628s (-0.12%)

[GuillaumeGomez]

I'm surprised it's all marked as "non-relevant".

For instructions count:

For RSS:

[Kobzol]

It's based both on the historical data and the magnitude of change. So here it was determined that these benchmarks were "noisy enough" recently and that the current change was not large enough in magnitude for it to be deemed relevant.

[GuillaumeGomez]

I see, makes sense. Thanks for the clarification.

[notriddle]

It’s fine. Removing unnecessary clones is just good practice anyway.

@bors r+

[bors]

📌 Commit 148a0c1 has been approved by notriddle

It is now in the queue for this repository.

[bors]

⌛ Testing commit 148a0c1 with merge a8be6e0...

[bors]

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing a8be6e0 to master...

[rust-timer]

Finished benchmarking commit (a8be6e0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[2.7%, 2.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 651.166s -> 651.129s (-0.01%)