-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #114569
Rollup of 8 pull requests #114569
Commits on Jul 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 86433e6 - Browse repository at this point
Copy the full SHA 86433e6View commit details
Commits on Jul 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0f534d0 - Browse repository at this point
Copy the full SHA 0f534d0View commit details -
Fix sanitizer tests depending on filename
In the basic case, simply do the string substitution. For one case with many instances, capture the Itanium- mangled filename and assert its reuse instead.
Configuration menu - View commit details
-
Copy full SHA for 4d2957c - Browse repository at this point
Copy the full SHA 4d2957cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0671161 - Browse repository at this point
Copy the full SHA 0671161View commit details -
Configuration menu - View commit details
-
Copy full SHA for df2264a - Browse repository at this point
Copy the full SHA df2264aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45c284c - Browse repository at this point
Copy the full SHA 45c284cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ca0556 - Browse repository at this point
Copy the full SHA 0ca0556View commit details -
Configuration menu - View commit details
-
Copy full SHA for badba92 - Browse repository at this point
Copy the full SHA badba92View commit details -
Configuration menu - View commit details
-
Copy full SHA for f03b315 - Browse repository at this point
Copy the full SHA f03b315View commit details -
We raised our LLVM minimum to 15, so these tests seem pointless.
Configuration menu - View commit details
-
Copy full SHA for c81d3e2 - Browse repository at this point
Copy the full SHA c81d3e2View commit details
Commits on Aug 1, 2023
-
tests/run-make/unknown-mod-stdin: Ignore Windows
The test fails on Windows with the diff - = help: to create the module `unknown`, create file "unknown.rs" or "unknown/mod.rs" + = help: to create the module `unknown`, create file "unknown.rs" or "unknown\mod.rs" There is no need to run this test on Windows, so ignore it.
Configuration menu - View commit details
-
Copy full SHA for 392bfc6 - Browse repository at this point
Copy the full SHA 392bfc6View commit details
Commits on Aug 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 026c4b6 - Browse repository at this point
Copy the full SHA 026c4b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e47cd2f - Browse repository at this point
Copy the full SHA e47cd2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60e43bc - Browse repository at this point
Copy the full SHA 60e43bcView commit details
Commits on Aug 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5419abd - Browse repository at this point
Copy the full SHA 5419abdView commit details
Commits on Aug 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eb0fcc5 - Browse repository at this point
Copy the full SHA eb0fcc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 502af03 - Browse repository at this point
Copy the full SHA 502af03View commit details -
Apply suggestions from code review
Co-authored-by: Ralf Jung <post@ralfj.de>
Configuration menu - View commit details
-
Copy full SHA for 75277a6 - Browse repository at this point
Copy the full SHA 75277a6View commit details
Commits on Aug 7, 2023
-
Rollup merge of rust-lang#98935 - kellerkindt:option_retain, r=Mark-S…
…imulacrum Implement `Option::take_if` Tracking issue: rust-lang#98934 ACP: rust-lang/libs-team#70 [accepted]
Configuration menu - View commit details
-
Copy full SHA for bab20b4 - Browse repository at this point
Copy the full SHA bab20b4View commit details -
Rollup merge of rust-lang#114093 - Enselic:stdin-unknown-mod, r=Mark-…
…Simulacrum Add regression test for `echo 'mod unknown;' | rustc -` Closes rust-lang#65601 The bug is fixed since long ago, probably by rust-lang#69838 (see rust-lang#65601 (comment) for more details). Add a regression test so we can close the issue.
Configuration menu - View commit details
-
Copy full SHA for 61c55e3 - Browse repository at this point
Copy the full SHA 61c55e3View commit details -
Rollup merge of rust-lang#114229 - workingjubilee:nest-sanitizer-dir,…
… r=Mark-Simulacrum Nest tests/codegen/sanitizer*.rs tests in sanitizer dir The sanitizer tests are the largest and most meticulously tested set of tests in tests/codegen. That's good! They all clearly belong to a subject and thus could go in a directory, but are not, instead being placed simply in tests/codegen. That's bad! Fix this by placing them in their own directory and renaming them to be less repetitive after that move. A few tests are brittle, and embed their filename in the test's checks. This is acceptable for the ones where it is used only two times, but one test embeds the test's mangled filename in the test *over 50 times*! This may have been one of the things discouraging anyone from moving it, and thus from moving the set. Fortunately, I have some knowledge of Itanium mangling (involuntarily), regex, and the FileCheck syntax. With a capturing variable, FileCheck allows us to now move this test around again without diffing it on ~50 lines, while still guaranteeing that the mangled substring is the same each time. This also clarifies why the substring is repeated a zillion times, instead of being cryptic. They don't call it mangling because the result is pretty and easy to understand, but now it is slightly easier! Yay descriptive variables!
Configuration menu - View commit details
-
Copy full SHA for 1371773 - Browse repository at this point
Copy the full SHA 1371773View commit details -
Rollup merge of rust-lang#114230 - workingjubilee:codegen-tests-that-…
…nest, r=Mark-Simulacrum Nest other codegen test topics This PR is like rust-lang#114229 in that it mostly pushes codegen tests around, shoving them into their own directories, but because all of the changes are very simple cleanups I pulled them into a separate PR. The other PR might involve actually evaluating the correctness of the test after changes, but here it is mostly a matter of taste. The only "functional" change is deleting a few tests that... hinge on a version of LLVM that we don't support (as of rust-lang#114148 anyways). I considered a few different ways to group other topics but I feel the question of whether `tests/codegen/{vec,array,slice}` should exist is more subtle than these choices, as it might be better to group such related tests by other topics like bounds check elision, thus I avoided making it.
Configuration menu - View commit details
-
Copy full SHA for fe1c3a1 - Browse repository at this point
Copy the full SHA fe1c3a1View commit details -
Rollup merge of rust-lang#114362 - tshepang:patch-1, r=Mark-Simulacrum
string.rs: remove "Basic usage" text Only a single example is given
Configuration menu - View commit details
-
Copy full SHA for 59d2a4b - Browse repository at this point
Copy the full SHA 59d2a4bView commit details -
Rollup merge of rust-lang#114365 - tshepang:patch-6, r=Mark-Simulacrum
str.rs: remove "Basic usage" text Only one example is given
Configuration menu - View commit details
-
Copy full SHA for f5df519 - Browse repository at this point
Copy the full SHA f5df519View commit details -
Rollup merge of rust-lang#114382 - scottmcm:compare-bytes-intrinsic, …
…r=cjgillot Add a new `compare_bytes` intrinsic instead of calling `memcmp` directly As discussed in rust-lang#113435, this lets the backends be the place that can have the "don't call the function if n == 0" logic, if it's needed for the target. (I didn't actually *add* those checks, though, since as I understood it we didn't actually need them on known targets?) Doing this also let me make it `const` (unstable), which I don't think `extern "C" fn memcmp` can be. cc `@RalfJung` `@Amanieu`
Configuration menu - View commit details
-
Copy full SHA for cbe2522 - Browse repository at this point
Copy the full SHA cbe2522View commit details -
Rollup merge of rust-lang#114549 - chenyukang:yukang-review-resolve-p…
…art, r=petrochenkov Style fix and refactor on resolve diagnostics - coding style - refactor api of `span_look_ahead`
Configuration menu - View commit details
-
Copy full SHA for d804b74 - Browse repository at this point
Copy the full SHA d804b74View commit details