Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add OS labels to std PRs #114930

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

ChrisDenton
Copy link
Member

I'd love to have library/std/src/sys PRs that touch Windows stuff to have the O-windows label for easier discovery (and rediscovery). While I'm here I added a couple of other auto OS labels. Perhaps O-unix is a little too broad but it's hard to be more specific and I think it's still useful insomuch as POSIX is a thing.

r? libs

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2023
@cuviper
Copy link
Member

cuviper commented Aug 21, 2023

Perhaps O-unix is a little too broad but it's hard to be more specific and I think it's still useful insomuch as POSIX is a thing.

I think unix is ok, but there are also more specific paths under std/src/os/ -- should we label all possible?

@ChrisDenton
Copy link
Member Author

Sounds good. Unless I'm missing something, I can't find labels for hermit, itron or solid.

@ChrisDenton
Copy link
Member Author

Ok, so I went ahead and created some new O- labels. They can always be changed/removed if they're unhelpful.

@cuviper
Copy link
Member

cuviper commented Aug 22, 2023

It seems you added the rest of src/sys, but not src/os? I'm hoping for O-linux at least. :)

@ChrisDenton
Copy link
Member Author

ChrisDenton commented Aug 22, 2023

I admit I was concentrating on sys/ and only added os/ as an afterthought. I've now added a bunch os/ only labels.

@cuviper
Copy link
Member

cuviper commented Aug 22, 2023

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 22, 2023

📌 Commit ca055f1 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 23, 2023
Automatically add OS labels to std PRs

I'd love to have `library/std/src/sys` PRs that touch Windows stuff to have the `O-windows` label for easier discovery (and rediscovery). While I'm here I added a couple of other auto OS labels. Perhaps `O-unix` is a little too broad but it's hard to be more specific and I think it's still useful insomuch as POSIX is a thing.

r? libs
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2023
Rollup of 7 pull requests

Successful merges:

 - rust-lang#114930 (Automatically add OS labels to std PRs)
 - rust-lang#115053 (docs: Add example, reference link for `type` keyword.)
 - rust-lang#115092 (Add generics_of to smir)
 - rust-lang#115096 (Add regression test for not `memcpy`ing padding bytes)
 - rust-lang#115100 (Add support for `ptr::write`s for the `invalid_reference_casting` lint)
 - rust-lang#115114 (Contents of reachable statics is reachable)
 - rust-lang#115122 (Fix clippy lint for identical `if`/`else` contraining `?` expressions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0718b75 into rust-lang:master Aug 23, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants