Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newtype_index for IntVid and FloatVid. #115634

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Use newtype_index for IntVid and FloatVid. #115634

merged 1 commit into from
Sep 8, 2023

Conversation

nnethercote
Copy link
Contributor

TyVid already uses newtype_index.

@nnethercote
Use newtype_index for IntVid and FloatVid.
a932990 
`TyVid` already uses `newtype_index`.
@rustbot
Copy link
Collaborator

rustbot commented Sep 7, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 7, 2023
@nnethercote
Copy link
Contributor Author

@bors rollup

@oli-obk
Copy link
Contributor

oli-obk commented Sep 7, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Sep 7, 2023

📌 Commit a932990 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 7, 2023
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 7, 2023
@GuillaumeGomez
Rollup merge of rust-lang#115634 - nnethercote:IntVid-FloatVid, r=oli…
d533ddf 
…-obk

Use `newtype_index` for `IntVid` and `FloatVid`.

`TyVid` already uses `newtype_index`.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 7, 2023
@GuillaumeGomez
Rollup merge of rust-lang#115634 - nnethercote:IntVid-FloatVid, r=oli…
7e450c1 
…-obk

Use `newtype_index` for `IntVid` and `FloatVid`.

`TyVid` already uses `newtype_index`.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 7, 2023
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 7, 2023
@GuillaumeGomez
Rollup merge of rust-lang#115634 - nnethercote:IntVid-FloatVid, r=oli…
3be5b96 
…-obk

Use `newtype_index` for `IntVid` and `FloatVid`.

`TyVid` already uses `newtype_index`.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 7, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2023
@bors
Auto merge of rust-lang#115651 - GuillaumeGomez:rollup-hysmaco, r=Gui…
38e57e1 
…llaumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#115345 (MCP661: Move wasm32-wasi-preview1-threads target to Tier 2)
 - rust-lang#115604 (rustdoc: Render private fields in tuple struct as `/* private fields */`)
 - rust-lang#115624 (Print the path of a return-position impl trait in trait when `return_type_notation` is enabled)
 - rust-lang#115629 (Don't suggest dereferencing to unsized type)
 - rust-lang#115633 (Lint node for `PRIVATE_BOUNDS`/`PRIVATE_INTERFACES` is the item which names the private type)
 - rust-lang#115634 (Use `newtype_index` for `IntVid` and `FloatVid`.)
 - rust-lang#115638 (`-Cllvm-args` usability improvement)
 - rust-lang#115649 (diagnostics: add test case for trait bounds diagnostic)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 8, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2023
@bors
Auto merge of rust-lang#115665 - matthiaskrgr:rollup-azdjs2r, r=matth…
de4cba3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#115345 (MCP661: Move wasm32-wasi-preview1-threads target to Tier 2)
 - rust-lang#115604 (rustdoc: Render private fields in tuple struct as `/* private fields */`)
 - rust-lang#115624 (Print the path of a return-position impl trait in trait when `return_type_notation` is enabled)
 - rust-lang#115629 (Don't suggest dereferencing to unsized type)
 - rust-lang#115634 (Use `newtype_index` for `IntVid` and `FloatVid`.)
 - rust-lang#115649 (diagnostics: add test case for trait bounds diagnostic)
 - rust-lang#115655 (rustdoc: remove unused ID `mainThemeStyle`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1979772 into rust-lang:master Sep 8, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 8, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2023
@bors
Auto merge of rust-lang#115651 - GuillaumeGomez:rollup-hysmaco, r=Gui…
2a5cf59 
…llaumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#115345 (MCP661: Move wasm32-wasi-preview1-threads target to Tier 2)
 - rust-lang#115604 (rustdoc: Render private fields in tuple struct as `/* private fields */`)
 - rust-lang#115624 (Print the path of a return-position impl trait in trait when `return_type_notation` is enabled)
 - rust-lang#115629 (Don't suggest dereferencing to unsized type)
 - rust-lang#115633 (Lint node for `PRIVATE_BOUNDS`/`PRIVATE_INTERFACES` is the item which names the private type)
 - rust-lang#115634 (Use `newtype_index` for `IntVid` and `FloatVid`.)
 - rust-lang#115638 (`-Cllvm-args` usability improvement)
 - rust-lang#115649 (diagnostics: add test case for trait bounds diagnostic)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2023
@rust-timer
Unrolled build for rust-lang#115634
2b65e8c 
Rollup merge of rust-lang#115634 - nnethercote:IntVid-FloatVid, r=oli-obk

Use `newtype_index` for `IntVid` and `FloatVid`.

`TyVid` already uses `newtype_index`.
@nnethercote nnethercote deleted the IntVid-FloatVid branch September 10, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nnethercote @rustbot @oli-obk @bors