Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #115755

Closed
wants to merge 16 commits into from
Closed

Commits on Sep 6, 2023

  1. Configuration menu
    Copy the full SHA
    3988ff2 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. fixes rust-lang#114896

    surechen committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a8f3c76 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Update mailmap

    jonas-schievink committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    8488c27 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Configuration menu
    Copy the full SHA
    254e13d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ce3b044 View commit details
    Browse the repository at this point in the history
  3. Generalize E0401

    fmease committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    b00e408 View commit details
    Browse the repository at this point in the history
  4. Make E0401 translatable

    fmease committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    9b36252 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    daf3c45 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    30e6cea View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Rollup merge of rust-lang#115308 - chenyukang:yukang-fix-62387-iter-m…

    …ut, r=davidtwco
    
    suggest iter_mut() where trying to modify elements from .iter()
    
    Fixes rust-lang#115259
    Fixes rust-lang#62387
    Dylan-DPC authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    93464a1 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#115595 - surechen:114896, r=davidtwco

    Fix incorrect mutable suggestion information for binding in ref pattern like:  `let &b = a;`
    
    fixes rust-lang#114896
    
    I find we have to get pat_span but not local_decl.source_info.span for suggestion. In `let &b = a;`  pat_span is &b. I think check `let &b = a` in hir to make sure it is hir::Node::Local(hir::Local {pat: hir::Pat{kind: hir::PatKind::Ref(.......   can distinguish it from other situation, but I'm not sure.
    
    If my processing method is not accurate, please guide me to modify it, thank you.
    
    r? `@davidtwco`
    Dylan-DPC authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    de79012 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0a9ecfd View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#115708 - RalfJung:homogeneous, r=davidtwco

    fix homogeneous_aggregate not ignoring some ZST
    
    This is an ABI-breaking change, because it fixes bugs in our ABI code. I'm not sure what that means for this PR, we don't really have a process for such changes, do we? I can only hope nobody relied on the old buggy behavior.
    
    Fixes rust-lang#115664
    Dylan-DPC authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    af9c4c1 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#115739 - Alexendoo:lint-pass-check-attribut…

    …e, r=oli-obk
    
    Call `LateLintPass::check_attribute` from `with_lint_attrs`
    
    Fixes rust-lang#115571
    
    For regular `register_late_pass` lints also means that `last_node_with_lint_attrs` is correct when in `check_attribute`, I've added a test that previously failed for `clippy::allow_attributes`
    
    As far as I can see the only late lint in rustc that uses `check_attribute` is `unstable_features` which is allow by default and deprecated so this is mostly for clippy (or future rustc lints)
    Dylan-DPC authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b829a5f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#115743 - compiler-errors:no-impls, r=davidtwco

    Point out if a local trait has no implementations
    
    Slightly helps with rust-lang#115741
    Dylan-DPC authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7270f85 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#115744 - fmease:fix-e0401, r=compiler-errors

    Improve diagnostic for generic params from outer items (E0401)
    
    Generalize the wording of E0401 to talk about *outer items* instead of *outer functions* since the current phrasing is outdated. The outer item can be a function, constant, trait, ADT or impl block (see the new UI test for the more exotic examples).
    
    Further, don't suggest introducing generic parameters to constant items unless the feature `generic_const_items` is enabled.
    
    Lastly, make E0401 translatable while we're at it.
    
    Fixes rust-lang#115720.
    Dylan-DPC authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    0fe3b15 View commit details
    Browse the repository at this point in the history