Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #116222

Merged
merged 14 commits into from
Sep 28, 2023
Merged

Rollup of 6 pull requests #116222

merged 14 commits into from
Sep 28, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tbu- and others added 14 commits June 27, 2023 17:22
Refer to the error instead of expanding its name.
error: unresolved link to `std::fmt::Error`
       --> library/core/src/fmt/mod.rs:115:52
        |
    115 |     /// This function will return an instance of [`std::fmt::Error`] on error.
        |
        |
        = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
Change the wording in `std::fmt::Write::write_str`

Refer to the error instead of expanding its name.
format doc-comment code examples in std::process
…eq, r=dtolnay

fix a comment about assert_receiver_is_total_eq

"a type implements #[deriving]" doesn't make any sense, so I assume they meant "implement `Eq`"? Also the attribute is called `derive`.
…rrors

more clippy complextity fixes

redundant_guards, useless_format, clone_on_copy
Document -Zlink-native-libraries

Originally added in rust-lang#70095.
…tweak, r=compiler-errors

Tweak wording of missing angle backets in qualified path
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 28, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Sep 28, 2023

📌 Commit 86d5939 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023
@bors
Copy link
Contributor

bors commented Sep 28, 2023

⌛ Testing commit 86d5939 with merge 6e09cff...

@bors
Copy link
Contributor

bors commented Sep 28, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 6e09cff to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2023
@bors bors merged commit 6e09cff into rust-lang:master Sep 28, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 28, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#112959 Change the wording in std::fmt::Write::write_str b630245d4d290bb3358ea9884a90d01506049dff (link)
#115535 format doc-comment code examples in std::process 45b31c66355c968c58549f6404b6d06c768dc956 (link)
#115888 fix a comment about assert_receiver_is_total_eq cf0dd8828048ccb7f54924591ee281a11349f7c4 (link)
#116211 more clippy complextity fixes 1263d09f71549603c5905a4853a7933d5750ec79 (link)
#116213 Document -Zlink-native-libraries 7241373173cfeb49b477da0159935730c0019711 (link)
#116215 Tweak wording of missing angle backets in qualified path 9b75ee45b81bc0f559903391b5914ff3b1f17804 (link)

previous master: 46da927abb

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6e09cff): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.429s -> 631.917s (0.08%)
Artifact size: 317.33 MiB -> 317.29 MiB (-0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-dnag90q branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants