Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid repeated interning of env!("CFG_RELEASE") #117188

Merged
merged 10 commits into from
Oct 27, 2023
Merged

Avoid repeated interning of env!("CFG_RELEASE") #117188

merged 10 commits into from
Oct 27, 2023

Commits on Oct 26, 2023

  1. Touch up syn parsing in symbols macro

    @dtolnay
    dtolnay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    173dcb2 View commit details
    Browse the repository at this point in the history

  2. Represent symbol value as enum to prepare for supporting env vars

    @dtolnay
    dtolnay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ba17934 View commit details
    Browse the repository at this point in the history

  3. Add a Parse impl for symbol Value

    @dtolnay
    dtolnay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    95742ff View commit details
    Browse the repository at this point in the history

  4. Delete counter from symbols proc macro in favor of hashmap as source … 

    …of truth
    @dtolnay
    dtolnay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    8dea49a View commit details
    Browse the repository at this point in the history

  5. Move symbols macro map into a struct

    @dtolnay
    dtolnay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    726a43c View commit details
    Browse the repository at this point in the history

  6. Support environment variable for interned Symbol value

    @dtolnay
    dtolnay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    65f0253 View commit details
    Browse the repository at this point in the history

  7. Continue generating other symbols if an expr is not supported

    @dtolnay
    dtolnay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    1078250 View commit details
    Browse the repository at this point in the history

  8. Improve span of env-related errors

    @dtolnay
    dtolnay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    5563a9b View commit details
    Browse the repository at this point in the history

  9. Pre-intern a symbol for env!("CFG_RELEASE")

    @dtolnay
    dtolnay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ac4fa3f View commit details
    Browse the repository at this point in the history

  10. Fix symbols::tests::test_symbols 

        ---- symbols::tests::test_symbols stdout ----
    thread 'symbols::tests::test_symbols' panicked at library/proc_macro/src/bridge/client.rs:311:17:
    procedural macro API is used outside of a procedural macro
    @dtolnay
    dtolnay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c1552df View commit details
    Browse the repository at this point in the history