Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #117564

Merged
merged 15 commits into from
Nov 4, 2023
Merged

Rollup of 3 pull requests #117564

merged 15 commits into from
Nov 4, 2023

Commits on Nov 2, 2023

  1. Reorder

    Nadrieril committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    fedee8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f9a2f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    380c56c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d95f6a9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b60f08a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c198569 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fcd24fb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3760d91 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Use filter_map in try_par_for_each_in

    This simplifies the expression, especially for the rayon part, and also
    lets us drop the `E: Copy` constraint.
    cuviper committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    3984914 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    335156c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    746197c View commit details
    Browse the repository at this point in the history
  4. consts: remove dead code around i1 constant values

    `LLVMConstZext` recently got deleted, and it turns out (thanks to @nikic
    for knowing!) that this is dead code. Tests all pass for me without this
    logic, and per nikic:
    
    > We always generate constants in "relocatable bag of bytes"
    > representation, so you're never going to get a plain bool.
    
    So this should be a safe thing to do.
    
    r? @nikic
    @rustbot label: +llvm-main
    durin42 committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f8daa7d View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. Rollup merge of rust-lang#117343 - Nadrieril:cleanup_check_match, r=d…

    …avidtwco
    
    Cleanup `rustc_mir_build/../check_match.rs`
    
    The file had become pretty unwieldy, with a fair amount of duplication. As a bonus, I discovered that we weren't running some pattern checks in if-let chains.
    
    I recommend looking commit-by-commit. The last commit is a whim, I think it makes more sense that way but I don't hold this opinion strongly.
    TaKO8Ki authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    9b9ea77 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#117550 - cuviper:try_par_for_each_in, r=est31

    Use `filter_map` in `try_par_for_each_in`
    
    This simplifies the expression, especially for the rayon part, and also
    lets us drop the `E: Copy` constraint.
    TaKO8Ki authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    c9c8513 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#117554 - durin42:llvm-delete-dead-zext-code…

    …, r=nikic
    
    consts: remove dead code around `i1` constant values
    
    `LLVMConstZext` recently got deleted, and it turns out (thanks to `@nikic` for knowing!) that this is dead code. Tests all pass for me without this logic, and per nikic:
    
    > We always generate constants in "relocatable bag of bytes"
    > representation, so you're never going to get a plain bool.
    
    So this should be a safe thing to do.
    
    r? `@nikic`
    `@rustbot` label: +llvm-main
    TaKO8Ki authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    c55bf0e View commit details
    Browse the repository at this point in the history