Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Regression test for assert!(!false) #119011

Merged
merged 1 commit into from
Dec 17, 2023
Merged

coverage: Regression test for assert!(!false) #119011

merged 1 commit into from
Dec 17, 2023

Conversation

Zalathar
Copy link
Contributor

This verifies that #118904 has already been fixed by #118198.

@rustbot label +A-code-coverage

@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) labels Dec 16, 2023
@Zalathar Zalathar mentioned this pull request Dec 16, 2023
Closed
@est31
Copy link
Member

est31 commented Dec 16, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Dec 16, 2023

📌 Commit bc77717 has been approved by est31

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 16, 2023
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 16, 2023
@GuillaumeGomez
Rollup merge of rust-lang#119011 - Zalathar:assert-not, r=est31
f621cd8 
coverage: Regression test for `assert!(!false)`

This verifies that rust-lang#118904 has already been fixed by rust-lang#118198.

---

`@rustbot` label +A-code-coverage
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 17, 2023
@bors
Auto merge of rust-lang#119030 - GuillaumeGomez:rollup-sb5e7wi, r=Gui…
1ed2eb8 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#118828 (Remove dead codes in rustc_codegen_gcc)
 - rust-lang#118830 (Add support for `--env` on `tracked_env::var`)
 - rust-lang#119001 (rustdoc-search: remove parallel searchWords array)
 - rust-lang#119011 (coverage: Regression test for `assert!(!false)`)
 - rust-lang#119020 (remove `hex` dependency in bootstrap)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Dec 17, 2023

⌛ Testing commit bc77717 with merge 9022e6a...

@bors
Copy link
Contributor

bors commented Dec 17, 2023

☀️ Test successful - checks-actions
Approved by: est31
Pushing 9022e6a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2023
@bors bors merged commit 9022e6a into rust-lang:master Dec 17, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 17, 2023
@Zalathar Zalathar deleted the assert-not branch December 17, 2023 04:36
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9022e6a): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.8%] 4
Regressions ❌
(secondary)		 0.5% [0.3%, 0.6%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [0.7%, 0.8%] 4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)		 4.1% [4.1%, 4.1%] 1
Improvements ✅
(primary)		 -3.1% [-3.1%, -3.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.0% [-3.1%, 1.0%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.517s -> 672.2s (-0.05%)
Artifact size: 312.37 MiB -> 312.39 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Dec 17, 2023
@pnkfelix
Copy link
Member

pnkfelix commented Dec 19, 2023 •
edited
Loading

yet again, helloworld check is being flagged as regressing (in four scenarios), probably due to wriggling noise threshold.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Zalathar @rustbot @est31 @bors @rust-timer @pnkfelix @Mark-Simulacrum