[MCP 723] Rename `astconv::AstConv` and related items #120926

fmease · 2024-02-11T10:16:42Z

See rust-lang/compiler-team#723.
Corresponding rustc-dev-guide PR: rust-lang/rustc-dev-guide#1916.

Please consult the following normative list of changes here:
https://fmease.dev/rustc-dev/astconv-no-mo.html (2024-03-22 archive link).

compiler/rustc_ast_lowering/src/item.rs

compiler/rustc_hir_analysis/src/astconv/mod.rs

compiler/rustc_hir_analysis/src/lib.rs

compiler/rustc_hir_analysis/src/astconv/bounds.rs

Split from the main renaming commit to make git generate a proper diff for ease of reviewing.

This makes it easier to read the trait definition for newcomers: Sorted from least “complex” to most “complex” followed by trivial “plumbing” and grouped by area. * Move `allow_infer` above all `*_infer` methods * It's the least complex method of those * Allows the `*_infer` to be placed right next to each other * Move `probe_ty_param_bounds` further down right next to `lower_assoc_ty` and `probe_adt` * It's more complex than the `infer` methods, it should come “later” * Now all required lowering functions are grouped together * Move the “plumbing” function `set_tainted_by_errors` further down below any actual lowering methods. * Provided method should come last

rustbot · 2024-03-22T05:53:19Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

fmease · 2024-03-22T05:53:27Z

Alrighty, the renaming of items and the updating of all relevant (doc) comments has been completed at last!

Best reviewed commit by commit. Some commits contain a short explainer outlining the motivation for the respective changes if not entirely obvious.

Please consult the following exhaustive & normative list of changes here:
https://fmease.dev/rustc-dev/astconv-no-mo.html (2024-03-22 archive link).
The MCP doesn't contain every single change but it does contain the majority of it.

Feel free to suggest better names for individual items but keep in mind that most of the name changes are well motivated and are part of a cohesive naming scheme. If you do please double-check first if there's an explainer for the name change in question over at the linked web page.

Ping @oli-obk @compiler-errors

oli-obk · 2024-03-22T08:33:41Z

<3 Thanks for doing this. The html doc is amazing. Still reading the doc, then will give this PR a review

@bors p=10 bitrotty

oli-obk · 2024-03-22T08:42:08Z

compiler/rustc_hir_analysis/src/astconv/bounds.rs

-    /// **A note on binders:** there is an implied binder around
-    /// `param_ty` and `ast_bounds`. See `instantiate_poly_trait_ref`
-    /// for more details.
+    /// There is an implied binder around `param_ty` and `ast_bounds`.


What does "implied binder" mean here? If no binder is specified, you get an empty binder?

It just means that param_ty: Ty<'tcx> may contain late-bound vars even though it's not wrapped in a Binder<'tcx, ·> (rendering them escaping I guess). Neither is ast_bounds/hir_bounds but well that param is of a HIR data type, so obviously it can't be wrapped in a Binder.

Wording is a bit poor, I guess I could've adjusted it.

oli-obk · 2024-03-22T08:54:14Z

compiler/rustc_trait_selection/src/traits/object_safety.rs

@@ -37,6 +37,7 @@ pub use crate::traits::{MethodViolationCode, ObjectSafetyViolation};
 /// Currently that is `Self` in supertraits. This is needed
 /// because `object_safety_violations` can't be used during
 /// type collection.
+#[instrument(level = "debug", skip(tcx))]


could also use ret here

oli-obk · 2024-03-22T08:55:40Z

@bors r+

bors · 2024-03-22T08:55:42Z

📌 Commit 5e73a8b has been approved by oli-obk

It is now in the queue for this repository.

bors · 2024-03-22T10:28:43Z

⌛ Testing commit 5e73a8b with merge eff958c...

bors · 2024-03-22T12:28:35Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing eff958c to master...

rust-timer · 2024-03-22T13:43:21Z

Finished benchmarking commit (eff958c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.305s -> 669.088s (-0.03%)
Artifact size: 315.01 MiB -> 314.99 MiB (-0.01%)

fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. labels Feb 11, 2024

fmease mentioned this pull request Feb 11, 2024

Rename astconv::AstConv and related items rust-lang/compiler-team#723

Closed

3 tasks

fmease commented Feb 11, 2024

View reviewed changes

compiler/rustc_ast_lowering/src/item.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

fmease commented Feb 11, 2024

View reviewed changes

compiler/rustc_hir_analysis/src/astconv/mod.rs Show resolved Hide resolved

fmease commented Feb 11, 2024

View reviewed changes

compiler/rustc_hir_analysis/src/lib.rs Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

fmease force-pushed the astconv-no-mo branch from 3e1e308 to 201c622 Compare February 11, 2024 20:30

rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative label Feb 11, 2024

fmease force-pushed the astconv-no-mo branch from 201c622 to f50fbe5 Compare February 11, 2024 21:38

This comment was marked as resolved.

Sign in to view

fmease mentioned this pull request Feb 12, 2024

Dejargonize subst #120958

Merged

fmease force-pushed the astconv-no-mo branch from f50fbe5 to 3815e2d Compare February 17, 2024 02:56

fmease commented Feb 18, 2024

View reviewed changes

compiler/rustc_hir_analysis/src/astconv/bounds.rs Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

fmease force-pushed the astconv-no-mo branch from 3815e2d to 3afdd34 Compare February 19, 2024 06:40

This comment has been minimized.

Sign in to view

fmease commented Feb 19, 2024

View reviewed changes

compiler/rustc_hir_analysis/src/astconv/bounds.rs Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

fmease removed the S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. label Feb 21, 2024

fmease changed the title ~~[WIP] [waiting on MCP] Rename astconv::AstConv and related items~~ [WIP] [MCP 723] Rename astconv::AstConv and related items Feb 21, 2024

fmease added 3 commits March 22, 2024 06:32

Rename module astconv to hir_ty_lowering

6d5a939

Split from the main renaming commit to make git generate a proper diff for ease of reviewing.

Notify fmease on changes to HIR ty lowering

5e73a8b

fmease force-pushed the astconv-no-mo branch from 20fc3cf to 5e73a8b Compare March 22, 2024 05:34

fmease marked this pull request as ready for review March 22, 2024 05:53

fmease changed the title ~~[WIP] [MCP 723] Rename astconv::AstConv and related items~~ [MCP 723] Rename astconv::AstConv and related items Mar 22, 2024

fmease added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 22, 2024

oli-obk approved these changes Mar 22, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2024

lcnr mentioned this pull request Mar 22, 2024

Split hir ty lowerer's error reporting code in check functions to mod errors. #122865

Merged

matthiaskrgr mentioned this pull request Mar 22, 2024

Rollup of 7 pull requests #122867

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 22, 2024

bors merged commit eff958c into rust-lang:master Mar 22, 2024
12 checks passed

rustbot added this to the 1.79.0 milestone Mar 22, 2024

fmease deleted the astconv-no-mo branch March 22, 2024 12:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MCP 723] Rename `astconv::AstConv` and related items #120926

[MCP 723] Rename `astconv::AstConv` and related items #120926

fmease commented Feb 11, 2024 •

edited

Loading

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment has been minimized.

This comment was marked as resolved.

rustbot commented Mar 22, 2024

fmease commented Mar 22, 2024 •

edited

Loading

oli-obk commented Mar 22, 2024

oli-obk Mar 22, 2024

fmease Mar 22, 2024 •

edited

Loading

oli-obk Mar 22, 2024

oli-obk commented Mar 22, 2024

bors commented Mar 22, 2024

bors commented Mar 22, 2024

bors commented Mar 22, 2024

rust-timer commented Mar 22, 2024

[MCP 723] Rename astconv::AstConv and related items #120926

[MCP 723] Rename astconv::AstConv and related items #120926

Conversation

fmease commented Feb 11, 2024 • edited Loading

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment has been minimized.

This comment was marked as resolved.

rustbot commented Mar 22, 2024

fmease commented Mar 22, 2024 • edited Loading

oli-obk commented Mar 22, 2024

oli-obk Mar 22, 2024

Choose a reason for hiding this comment

fmease Mar 22, 2024 • edited Loading

Choose a reason for hiding this comment

oli-obk Mar 22, 2024

Choose a reason for hiding this comment

oli-obk commented Mar 22, 2024

bors commented Mar 22, 2024

bors commented Mar 22, 2024

bors commented Mar 22, 2024

rust-timer commented Mar 22, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

[MCP 723] Rename `astconv::AstConv` and related items #120926

[MCP 723] Rename `astconv::AstConv` and related items #120926

fmease commented Feb 11, 2024 •

edited

Loading

fmease commented Mar 22, 2024 •

edited

Loading

fmease Mar 22, 2024 •

edited

Loading