-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #122236
Rollup of 11 pull requests #122236
Commits on Mar 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c3954b3 - Browse repository at this point
Copy the full SHA c3954b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d88c7ff - Browse repository at this point
Copy the full SHA d88c7ffView commit details -
skip sanity check for non-host targets in
check
buildsFor `check` builds, since we only need to perform a sanity check on the host target, this patch skips target sanity checks on non-host targets. Signed-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for 489dcf2 - Browse repository at this point
Copy the full SHA 489dcf2View commit details -
Avoid some interning in bootstrap
This interning is pointless and only makes the code more complex. The only remaining use of interning is `TargetSelection`, for which I left a comment.
Configuration menu - View commit details
-
Copy full SHA for fbb97ed - Browse repository at this point
Copy the full SHA fbb97edView commit details
Commits on Mar 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5c87ca2 - Browse repository at this point
Copy the full SHA 5c87ca2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20200f6 - Browse repository at this point
Copy the full SHA 20200f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c4eadd - Browse repository at this point
Copy the full SHA 6c4eaddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98dbe9a - Browse repository at this point
Copy the full SHA 98dbe9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4663fbb - Browse repository at this point
Copy the full SHA 4663fbbView commit details
Commits on Mar 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bef1cd8 - Browse repository at this point
Copy the full SHA bef1cd8View commit details -
I don't think it is necessary anymore. As I understand it from issue 39504 the original problem was that rustbuild changed a hardlink in the cargo build dir to point to copy in the sysroot while cargo may have hardlinked it to the original first. I don't think this happens anymore and as such this workaround is no longer necessary.
Configuration menu - View commit details
-
Copy full SHA for 446708b - Browse repository at this point
Copy the full SHA 446708bView commit details -
Move metadata header and version checks together
This will make it easier to report rustc versions for older metadata formats.
Configuration menu - View commit details
-
Copy full SHA for fdff4d7 - Browse repository at this point
Copy the full SHA fdff4d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87ab9e8 - Browse repository at this point
Copy the full SHA 87ab9e8View commit details
Commits on Mar 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 564837e - Browse repository at this point
Copy the full SHA 564837eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6aff1ca - Browse repository at this point
Copy the full SHA 6aff1caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1082c36 - Browse repository at this point
Copy the full SHA 1082c36View commit details -
Rollup merge of rust-lang#121567 - Nilstrieb:less-interning, r=albert…
…larsan68 Avoid some interning in bootstrap This interning is pointless and only makes the code more complex. The only remaining use of interning is `TargetSelection`, for which I left a comment.
Configuration menu - View commit details
-
Copy full SHA for f1f28a2 - Browse repository at this point
Copy the full SHA f1f28a2View commit details -
Rollup merge of rust-lang#121813 - Urgau:misc-non_local_defs-lint, r=…
…cjgillot Misc improvements to non local defs lint implementation This PR is a collection of small improvements I found when I [needlessly tried](https://www.github.com/rust-lang/rust/pull/120393#issuecomment-1971787475) to fix a "perf-regression" in the lint implementation. I recommend looking at each commit individually.
Configuration menu - View commit details
-
Copy full SHA for 36bf8bb - Browse repository at this point
Copy the full SHA 36bf8bbView commit details -
Rollup merge of rust-lang#121860 - mu001999:master, r=Nilstrieb
Add a tidy check that checks whether the fluent slugs only appear once As ``@Nilstrieb`` said in rust-lang#121828 (comment): > Might make sense to have a tidy check that checks whether the fluent slugs only appear once in the source code and lint for that there's a tidy check already for sorting We can get the tidy check error: ``` tidy check tidy error: /path/to/rust/compiler/rustc_const_eval/messages.ftl: message `const_eval_invalid_align` is not used tidy error: /path/to/rust/compiler/rustc_lint/messages.ftl: message `lint_trivial_untranslatable_diag` is not used tidy error: /path/to/rust/compiler/rustc_parse/messages.ftl: message `parse_invalid_literal_suffix` is not used tidy error: /path/to/rust/compiler/rustc_infer/messages.ftl: message `infer_need_type_info_in_coroutine` is not used tidy error: /path/to/rust/compiler/rustc_passes/messages.ftl: message `passes_expr_not_allowed_in_context` is not used tidy error: /path/to/rust/compiler/rustc_passes/messages.ftl: message `passes_layout` is not used tidy error: /path/to/rust/compiler/rustc_parse/messages.ftl: message `parse_not_supported` is not used ``` r? ``@Nilstrieb``
Configuration menu - View commit details
-
Copy full SHA for 3f4e877 - Browse repository at this point
Copy the full SHA 3f4e877View commit details -
Rollup merge of rust-lang#121907 - onur-ozkan:better-target-sanity-ch…
…eck, r=albertlarsan68 skip sanity check for non-host targets in `check` builds For `check` builds, since we only need to perform a sanity check on the host target, this patch skips target sanity checks on non-host targets. For more context, see rust-lang#121519 (comment) cc `@saethlin`
Configuration menu - View commit details
-
Copy full SHA for 36edf0f - Browse repository at this point
Copy the full SHA 36edf0fView commit details -
Rollup merge of rust-lang#122160 - jieyouxu:eager-translate-help-use-…
…latest-edition, r=cjgillot Eagerly translate `HelpUseLatestEdition` in parser diagnostics Fixes rust-lang#122130. This makes me suspicious of these other two usage of `add_to_diagnostic()`. Would they *also* crash? I haven't attempted to construct test cases for them. ``` compiler/rustc_parse/src/parser/expr.rs 3453: errors::HelpUseLatestEdition::new().add_to_diagnostic(e); compiler/rustc_hir_typeck/src/expr.rs 2603: HelpUseLatestEdition::new().add_to_diagnostic(&mut err); ``` This also seems like a footgun?
Configuration menu - View commit details
-
Copy full SHA for 63d1607 - Browse repository at this point
Copy the full SHA 63d1607View commit details -
Rollup merge of rust-lang#122178 - cuviper:ci-llvm-18, r=Kobzol
ci: add a runner for vanilla LLVM 18 For CI cost, this can be seen as replacing the llvm-15 runner we dropped in rust-lang#117947. Also, I've set `IS_NOT_LATEST_LLVM` in the llvm-17 runner, since that's not the latest anymore.
Configuration menu - View commit details
-
Copy full SHA for 1404734 - Browse repository at this point
Copy the full SHA 1404734View commit details -
Rollup merge of rust-lang#122186 - bjorn3:remove_bug_workaround, r=pe…
…trochenkov Remove a workaround for a bug I don't think it is necessary anymore. As I understand it from issue 39504 the original problem was that rustbuild changed a hardlink in the cargo build dir to point to copy in the sysroot while cargo may have hardlinked it to the original first. I don't think this happens anymore and as such this workaround is no longer necessary. Split out of rust-lang#120855
Configuration menu - View commit details
-
Copy full SHA for be4523b - Browse repository at this point
Copy the full SHA be4523bView commit details -
Rollup merge of rust-lang#122187 - bjorn3:merge_header_version_checks…
…, r=petrochenkov Move metadata header and version checks together This will make it easier to report rustc versions for older metadata formats. Split out of rust-lang#120855
Configuration menu - View commit details
-
Copy full SHA for 572cf4a - Browse repository at this point
Copy the full SHA 572cf4aView commit details -
Rollup merge of rust-lang#122215 - Zoxc:cycle-detect-names, r=oli-obk
Some tweaks to the parallel query cycle handler This renames `deadlock` to `break_query_cycles`. The abort logic is moved next to the thread spawning and gives the thread a name. Fixes rust-lang#122035. r? ``@oli-obk``
Configuration menu - View commit details
-
Copy full SHA for ad76f1b - Browse repository at this point
Copy the full SHA ad76f1bView commit details -
Rollup merge of rust-lang#122223 - Jarcho:visit_fix, r=oli-obk
Fix typo in `VisitorResult` r? ``@oli-obk``
Configuration menu - View commit details
-
Copy full SHA for 23898d8 - Browse repository at this point
Copy the full SHA 23898d8View commit details -
Rollup merge of rust-lang#122232 - RalfJung:misc, r=jhpratt
library/core: fix a comment, and a cfg(miri) warning Just two things I noticed while working on another PR.
Configuration menu - View commit details
-
Copy full SHA for 28fca59 - Browse repository at this point
Copy the full SHA 28fca59View commit details