Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register new snapshots #12272

Merged
merged 2 commits into from
Feb 15, 2014
Merged

Register new snapshots #12272

merged 2 commits into from
Feb 15, 2014

Conversation

alexcrichton
Copy link
Member

This notably contains the extern mod => extern crate change.

Closes #9880

@lilyball
Copy link
Contributor

Rather odd error, and the span is off too:

src/test/run-pass/issue-8860.rs:13:12: 13:17 error: `extern crate` is obsolete, use `extern crate` instead to refer to external crates.
src/test/run-pass/issue-8860.rs:13 extern mod green;
                                              ^~~~~

This enables the parser error for `extern mod` => `extern crate` transitions.
This was previously implemented, and it just needed a snapshot to go through
@flaper87
Copy link
Contributor

Looks like the s/extern mod/extern crate/ replacement changed the error message.

bors added a commit that referenced this pull request Feb 15, 2014
This notably contains the `extern mod` => `extern crate` change.

Closes #9880
@bors bors closed this Feb 15, 2014
@bors bors merged commit a41b0c2 into rust-lang:master Feb 15, 2014
@alexcrichton alexcrichton deleted the snapshot branch February 16, 2014 00:39
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
…fsets, r=jonas-schievink

fix: Fix signature help LSP offset conversion

Fixes rust-lang/rust-analyzer#12270

I don't think we really handle this correctly anywhere (eg. surrogates probably aren't counted right), but this at least fixes the immediately visible bug.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 26, 2024
Fix broken URL in `Lint Configuration`

Pretty sure it's meant to be `struct_field_names` and not `struct_variant_names`.

This change is gargantuan!!! review carefully

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reevaluate extern mod as syntax for importing crates.
4 participants