Stop using <DefId as Ord> in various diagnostic situations
#122820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
…d` ordering, which breaks incremental compilation.
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
estebank
reviewed
Mar 21, 2024
Comment on lines
-61
to
-64
| LL | / foo(cell, |cell_a, cell_x| { | ||
| LL | | cell_x.set(cell_a.get()); // forces 'a: 'x, implies 'a = 'static -> borrow error | ||
| LL | | }) | ||
| | |______- argument requires that `a` is borrowed for `'static` |
estebank
reviewed
Mar 21, 2024
Comment on lines
-73
to
-82
| let _ = transpose([[0; 8]; 16]); | ||
| let _ = transpose_with_const::<8,4>([[0; 8]; 16]); | ||
| let _ = ident([[0; 8]; 16]); | ||
| let _ = flatten([[0; 13]; 5]); | ||
| let _: [[_; 5]; 13] = coagulate([0; 65]); | ||
| let _ = flatten_3d([[[0; 3]; 13]; 5]); | ||
| let _ = flatten_somewhat([[[0; 3]; 13]; 5]); | ||
| let _ = known_size([16; 13]); | ||
| let _: [u16; 5] = condense_bytes([16u8; 10]); | ||
| let _ = singleton_each([16; 10]); |
There was a problem hiding this comment.
So all of these functions are no longer representable, right?
|
@bors r+ |
bors
added
S-waiting-on-bors
oli-obk
changed the title
<DefId as Ord> in vrious diagnostic situations
fmease
changed the title
<DefId as Ord> in vrious diagnostic situations<DefId as Ord> in various diagnostic situations
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2024
Remove `DefId`'s `Partial/Ord` impls work towards rust-lang#90317 based on rust-lang#122824 and rust-lang#122820 r? `@michaelwoerister`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121619 (Experimental feature postfix match) - rust-lang#122370 (Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()`) - rust-lang#122537 (interpret/allocation: fix aliasing issue in interpreter and refactor getters a bit) - rust-lang#122542 (coverage: Clean up marker statements that aren't needed later) - rust-lang#122800 (Add `NonNull::<[T]>::is_empty`.) - rust-lang#122820 (Stop using `<DefId as Ord>` in various diagnostic situations) - rust-lang#122847 (Suggest `RUST_MIN_STACK` workaround on overflow) - rust-lang#122855 (Fix Itanium mangling usizes) - rust-lang#122863 (add more ice tests ) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2024
Rollup merge of rust-lang#122820 - oli-obk:no_ord_def_id, r=estebank Stop using `<DefId as Ord>` in various diagnostic situations work towards rust-lang#90317 Reverts part of rust-lang#106281, as it sorts constants and that's problematic since it can contain `ParamConst`, which contains `DefId`s
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2024
…rister Remove `DefId`'s `Partial/Ord` impls work towards rust-lang#90317 based on rust-lang#122824 and rust-lang#122820 r? `@michaelwoerister`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 4, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121619 (Experimental feature postfix match) - rust-lang#122370 (Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()`) - rust-lang#122537 (interpret/allocation: fix aliasing issue in interpreter and refactor getters a bit) - rust-lang#122542 (coverage: Clean up marker statements that aren't needed later) - rust-lang#122800 (Add `NonNull::<[T]>::is_empty`.) - rust-lang#122820 (Stop using `<DefId as Ord>` in various diagnostic situations) - rust-lang#122847 (Suggest `RUST_MIN_STACK` workaround on overflow) - rust-lang#122855 (Fix Itanium mangling usizes) - rust-lang#122863 (add more ice tests ) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work towards #90317
Reverts part of #106281, as it sorts constants and that's problematic since it can contain
ParamConst, which containsDefIds