Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out PredicatePolarity from ImplPolarity #122839

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Split out PredicatePolarity from ImplPolarity #122839

merged 4 commits into from
Mar 23, 2024

Commits on Mar 22, 2024

  1. Split out ImplPolarity and PredicatePolarity

    @compiler-errors
    compiler-errors committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4b87c0b View commit details
    Browse the repository at this point in the history

  2. Use != Positive rather than == Negative 

    Feels more complete, and for ImplPolarity has the side-effect of making
sure we also handle reservation impls correctly
    @compiler-errors
    compiler-errors committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    127e42d View commit details
    Browse the repository at this point in the history

  3. Fix clippy

    @compiler-errors
    compiler-errors committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    560c6cc View commit details
    Browse the repository at this point in the history

  4. Further simplifications

    @compiler-errors
    compiler-errors committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    d677a2d View commit details
    Browse the repository at this point in the history