Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #123708

Merged
merged 24 commits into from
Apr 10, 2024
Merged

Rollup of 7 pull requests #123708

merged 24 commits into from
Apr 10, 2024

Commits on Apr 8, 2024

  1. move exit-code to rmake

    5225225 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    65df93b View commit details
    Browse the repository at this point in the history
  2. Store all args in the unsupported Command implementation

    This allows printing them in the Debug impl as well as getting them
    again using the get_args() method. This allows programs that would
    normally spawn another process to more easily show which program they
    would have spawned if not for the fact that the target doesn't support
    spawning child processes without requiring intrusive changes to keep the
    args. For example rustc compiled to wasi will show the full linker
    invocation that would have been done.
    bjorn3 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    bbd82ff View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Set target-abi module flag for RISC-V targets

    Fixes cross-language LTO on RISC-V targets (Fixes rust-lang#121924)
    kxxt committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    f19c48e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    adec1a2 View commit details
    Browse the repository at this point in the history
  3. Pass value and valueLen to create a StringRef

    Instead of creating a cstring.
    
    Co-authored-by: LoveSy <shana@zju.edu.cn>
    kxxt and yujincheng08 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    33db209 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    688e531 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    626fd4b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f014e91 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c7e77be View commit details
    Browse the repository at this point in the history
  8. Fix dead code warning

    bjorn3 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b4a395b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    09dab38 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a439eb2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3253c02 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    de79a6c View commit details
    Browse the repository at this point in the history
  13. Add a FIXME

    oli-obk committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    bf497b8 View commit details
    Browse the repository at this point in the history
  14. Iterate over parent captures first, as there is a 1:N mapping of pare…

    …nt captures to child captures
    oli-obk committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e14e795 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. remove does-nothing.rs

    fix: restore issues_entry_limit
    Oneirical committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    cbf1501 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#121884 - 5225225:rmake-exit-code, r=jieyouxu

    Port exit-code run-make test to use rust
    
    As part of rust-lang#121876
    
    ~~As draft because formatting will fail because `x fmt` isn't working for me for some reason, I'll debug that later, just opening this now for review, will mark as ready when formatting is fixed~~ (misleading message from x fmt)
    
    cc `@jieyouxu`
    matthiaskrgr authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a79b243 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#122200 - jieyouxu:unconditional-nightly-upd…

    …ate-hint, r=estebank
    
    Unconditionally show update nightly hint on ICE
    
    Instead of trying to guess if a update nightly hint should be shown (by checking for system time, querying version and channel info etc.), just show the update nightly hint for nightly compilers. This avoids breaking tests that match on ICE test outputs on nightly/dev channels.
    
    > Another issue is that the outdated nightly hint triggers for ICE tests, causing a mismatch with the test expectation. There doesn't seem to be any env var to suppress this.
    
    See <https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/stage0.20compiletest.20broken/near/425543681> for context.
    matthiaskrgr authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7dd24d8 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#123568 - Oneirical:delete-tests, r=wesleywiser

    Clean up tests/ui by removing `does-nothing.rs`
    
    In [a previous PR](rust-lang#123297 (comment)), it was suggested that this test be removed:
    
    > it's testing a basic diagnostic for an unknown variable (added over a decade ago for rust-lang#154) that is already covered by probably dozens or hundreds of other tests.
    
    It was then suggested that [opening a new PR](rust-lang#123563 (comment)) for this would be more organized.
    
    I'm setting this as a draft, as:
    
    1. The tests/ui directory is rather disorganized, a large quantity of tests are not even contained inside their own directories. This PR could turn into "clean up the UI tests directory", if I were to place everything into categories (for example, everything related to CLI flags could get placed in a cli directory).
    2. This will have a merge conflict with rust-lang#123563 should that get merged. I trust that _this time_, I won't run into [The Incident](rust-lang#123297 (comment)) while rebasing. Edit: Yay, I did it properly!
    matthiaskrgr authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c14b468 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#123609 - compiler-errors:greek-question-mar…

    …k, r=jieyouxu
    
    Don't use bytepos offsets when computing semicolon span for removal
    
    Causes problems when we recover confusable characters w/ a different byte width
    
    Fixes rust-lang#123607
    matthiaskrgr authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4bc891a View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#123612 - kxxt:riscv-target-abi, r=jieyouxu,…

    …nikic,DianQK
    
    Set target-abi module flag for RISC-V targets
    
    Fixes cross-language LTO on RISC-V targets (Fixes rust-lang#121924)
    matthiaskrgr authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2ddf984 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#123633 - bjorn3:unsupported_command_data, r…

    …=jhpratt
    
    Store all args in the unsupported Command implementation
    
    This allows printing them in the Debug impl as well as getting them again using the get_args() method. This allows programs that would normally spawn another process to more easily show which program they would have spawned if not for the fact that the target doesn't support spawning child processes without requiring intrusive changes to keep the args. For example rustc compiled to wasi will show the full linker invocation that would have been done.
    matthiaskrgr authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a3f10a4 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#123668 - oli-obk:by_move_body_golfing, r=co…

    …mpiler-errors
    
    async closure coroutine by move body MirPass refactoring
    
    Unsure about the last commit, but I think the other changes help in simplifying the control flow
    matthiaskrgr authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    df068db View commit details
    Browse the repository at this point in the history