Call lower_const_param instead of duplicating the code #123738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease |
compiler-errors
approved these changes
Apr 10, 2024
spastorino
force-pushed
the
reuse-lower-const-param
branch
from
6dead55
to
f9efcb1
Compare
|
@bors r=compiler-errors rollup |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
spastorino
force-pushed
the
reuse-lower-const-param
branch
from
f9efcb1
to
d51fda8
Compare
|
@bors r=compiler-errors rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 11, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#123660 (Make the computation of `coroutine_captures_by_ref_ty` more sophisticated) - rust-lang#123738 (Call lower_const_param instead of duplicating the code) - rust-lang#123774 (Fix typo MaybeUnit -> MaybeUninit) - rust-lang#123790 (correct the handling of `bootstrap-cache-path` option) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 11, 2024
Rollup merge of rust-lang#123738 - spastorino:reuse-lower-const-param, r=compiler-errors Call lower_const_param instead of duplicating the code Follow up of rust-lang#123689 r? `@oli-obk` I had this commit in my old branch that I had forgotten about, `@fmease` pointed about this in rust-lang#123689 I've left the branches that are not `Range` as do nothing as that's what we are currently doing but maybe we want to err or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #123689
r? @oli-obk
I had this commit in my old branch that I had forgotten about, @fmease pointed about this in #123689
I've left the branches that are not
Rangeas do nothing as that's what we are currently doing but maybe we want to err or something.