No libc msvc #123938
Closed
No libc msvc #123938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChrisDenton
force-pushed
the
no-libc-msvc
branch
from
9ab8df9
to
af760e1
Compare
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 15, 2024
…ingjubilee Use the rustc_private libc less in tests I started looking into our use of `rustc_private` + `extern crate libc;` in tests because of rust-lang#123938 and it looks like some fraction of the users of libc simply don't need the libc crate anymore.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2024
Rollup merge of rust-lang#123943 - saethlin:less-sysroot-libc, r=workingjubilee Use the rustc_private libc less in tests I started looking into our use of `rustc_private` + `extern crate libc;` in tests because of rust-lang#123938 and it looks like some fraction of the users of libc simply don't need the libc crate anymore.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 18, 2024
…=jieyouxu Remove libc from more tests The goal here is to trim down the number of tests that depend on libc from the sysroot to make rust-lang#123938 more plausible. This PR is a few simple cases that I missed in rust-lang#123943.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2024
…ieyouxu Remove libc from more tests The goal here is to trim down the number of tests that depend on libc from the sysroot to make rust-lang#123938 more plausible. This PR is a few simple cases that I missed in rust-lang#123943.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Apr 19, 2024
Remove libc from more tests The goal here is to trim down the number of tests that depend on libc from the sysroot to make rust-lang/rust#123938 more plausible. This PR is a few simple cases that I missed in rust-lang/rust#123943.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? ghost