Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable rust-lld on nightly x86_64-unknown-linux-gnu #124129

Merged
merged 6 commits into from
May 17, 2024
Merged

Enable rust-lld on nightly x86_64-unknown-linux-gnu #124129

merged 6 commits into from
May 17, 2024

Commits on May 16, 2024

  1. bootstrap: introduce rust-lld env var for rustc 

    This is used to notify we want to use rust-lld as the default linker in
a target.
    @lqd
    lqd committed May 16, 2024
    Configuration menu
    Copy the full SHA
    28ce76e View commit details
    Browse the repository at this point in the history

  2. bootstrap: enable rust-lld when necessary for x86_64-unknown-linux-gnu 

    `x86_64-unknown-linux-gnu` has switched to using the self-contained linker
by default (unless asked not to), so we have to build rust-lld:
- when we build our own llvm
- when we use download-ci-llvm
- otherwise, when using an external llvm we can't enable it
    @lqd
    lqd committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5f04f6d View commit details
    Browse the repository at this point in the history

  3. enable rust-lld on x86_64-unknown-linux-gnu when requested 

    the `rust.lld` config enables rustc's `CFG_USE_SELF_CONTAINED_LINKER` env var, and we:
- set the linker-flavor to use lld
- enable the self-contained linker

this makes the target use the rust-lld linker by default
    @lqd
    lqd committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7695e5a View commit details
    Browse the repository at this point in the history

  4. describe new default value for rust.lld in config template

    @lqd
    lqd committed May 16, 2024
    Configuration menu
    Copy the full SHA
    514765b View commit details
    Browse the repository at this point in the history

  5. test rust-lld is on by default on the x64 linux target

    @lqd
    lqd committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4d280de View commit details
    Browse the repository at this point in the history

  6. add bootstrap config change info about rust.lld 

    the default value changes on `x86_64-unknown-linux-gnu`, and semantics kinda
as it will impact the target's default linker
    @lqd
    lqd committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3a90967 View commit details
    Browse the repository at this point in the history