Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #124442

Closed
wants to merge 16 commits into from

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    b52e4bd View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    babead5 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Configuration menu
    Copy the full SHA
    82cc02a View commit details
    Browse the repository at this point in the history
  2. add test for ICE: tcx.resolutions(()) is not supported for local crat…

    …e -Zunpretty=mir on invalid module path with staged_ap
    
    Fixes rust-lang#108697
    matthiaskrgr committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    24829ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    52ab0b6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1adf750 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3d1a1db View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6a5f02b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a54988a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f7b9861 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4faaa53 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#124370 - ShE3py:substitution-part-offset, r…

    …=fee1-dead
    
    Fix substitution parts having a shifted underline in some cases
    
    If two suggestions parts are side by side, the underline's offset:
    (WIP PR as an example, not yet pushed)
    ```
    error: expected a pattern, found an expression
     --> ./main.rs:4:9
      |
    4 |         1 + 2 => 3
      |         ^^^^^ arbitrary expressions are not allowed in patterns
      |
    help: check the value in an arm guard
      |
    4 |         n if n == 1 + 2 => 3
      |         ~     +++++++++++++
    ```
    The emitter didn't take into account that the string had shrunk/grown if two substitution parts were side-by-side (surprisingly, there was only one case in the ui testsuite.)
    
    ```
    help: check the value in an arm guard
      |
    4 |         n if n == 1 + 2 => 3
      |         ~ +++++++++++++
    ```
    
    `@rustbot` label +A-suggestion-diagnostics
    matthiaskrgr authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    09a2a71 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#124405 - RalfJung:miri-core-alloc-tests, r=…

    …clubby789
    
    miri core/alloc tests: do not test a 2nd target
    
    check-aux seems to be one of the slowest runners since we started running standard library tests in Miri on it. So maybe it'd be better to reduce test coverage a bit by not doing cross-target testing of core and alloc? I don't recall finding target-specific issues in these libraries ever (and we still have the extra test coverage via our [out-of-tree nightly tests](https://github.com/rust-lang/miri-test-libstd)). This gives us more buffer to deal with the fact that the number of tests we run will only grow over time.
    
    Cc `@rust-lang/miri` `@rust-lang/infra`
    matthiaskrgr authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    a6b35f5 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#124425 - saethlin:ceci-nest-pas-une-ice, r=…

    …compiler-errors
    
    Do not ICE on invalid consts when walking mono-reachable blocks
    
    The `bug!` here was written under the logic of "this condition is impossible, right?" except that of course, if the compiler is given code that results in an compile error, then the situation is possible.
    
    So now we just direct errors into the already-existing path for when we can't do a mono-time optimization.
    matthiaskrgr authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    af621a4 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#124435 - matthiaskrgr:tests, r=jieyouxu

    add more tests
    
    r? `@jieyouxu`
    matthiaskrgr authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    625f5d4 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#124437 - linyihai:doc-link-typeck, r=compil…

    …er-errors
    
    doc: Make the `mod.rs` in the comment point to the correct location
    
    The origin `mod.rs` had moved to `rustc_hir_analysis::check`, but the annotation doesn't point to it.
    
    See [the origin PR](https://github.com/rust-lang/rust/pull/61857/files#diff-b65997b61ccd8d8e08238c925d631207671aca506e93ce7c5cfa0bec134c0a8e).
    matthiaskrgr authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    03a1bd8 View commit details
    Browse the repository at this point in the history