Disallow hidden references to mutable static

[obeis]

Closes #123060

Tracking:

• Tracking Issue for Rust 2024: Deny references to static mut #123758

[RalfJung]

Sorry, I can only review interpreter and Miri PRs.

r? compiler

[obeis]

r? @davidtwco

[davidtwco]

Marking as waiting on author since you've made this a draft.

[rustbot]

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[obeis]

@rustbot ready

[compiler-errors]

There are also some random stray files that need to be deleted:

• compiler/rustc_lint_defs/src/lib.rs:11:5
• compiler/rustc_lint_defs/src/lib.rs:887:48

[compiler-errors]

I'd personally rather we try to make this lint a bit less trigger-prone if possible. I'd be fine even if we implement it only for totally unconstrained late-bound receiver lifetimes where the lifetime does not show up in the return type or something like that.

But that's my personal opinion; I guess if T-lang is fine with this amount of churn then whatever.

[michaelwoerister]

r? @compiler-errors -- I'm not a good reviewer for this other than the basics.

[bors]

☔ The latest upstream changes (presumably #107251) made this pull request unmergeable. Please resolve the merge conflicts.

[obeis]

@compiler-errors Done.

[compiler-errors]

I'd personally rather we try to make this lint a bit less trigger-prone if possible. I'd be fine even if we implement it only for totally unconstrained late-bound receiver lifetimes where the lifetime does not show up in the return type or something like that.

I don't think this actually ever got fixed, but whatever.

@bors r+

[bors]

📌 Commit 3b0ce1b has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3b0ce1b with merge 5ba6db1...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 5ba6db1 to master...

[rust-timer]

Finished benchmarking commit (5ba6db1): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	[1.1%, 1.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.8%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 7.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.1%	[7.1%, 7.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 767.803s -> 768.593s (0.10%)
Artifact size: 341.28 MiB -> 341.36 MiB (0.02%)