Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build the rust-demangler binary for coverage tests #125816

Merged
merged 4 commits into from
May 31, 2024
Merged

Don't build the rust-demangler binary for coverage tests #125816

merged 4 commits into from
May 31, 2024

Commits on May 31, 2024

  1. Add an alternate --demangle mode to coverage-dump 

    The coverage-dump tool already needs `rustc_demangle` for its own purposes, so
the amount of extra code needed for a demangle mode is very small.
    @Zalathar
    Zalathar committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9abfebd View commit details
    Browse the repository at this point in the history

  2. Use coverage-dump --demangle as the demangler for coverage-run tests 

    This avoids the need to build `rust-demangler` when running coverage tests,
since we typically need to build `coverage-dump` anyway.
    @Zalathar
    Zalathar committed May 31, 2024
    Configuration menu
    Copy the full SHA
    10ffc22 View commit details
    Browse the repository at this point in the history

  3. Use Builder::tool_exe to build the coverage-dump tool 

    This appears to be the canonical way to build a tool with the stage 0 compiler.
    @Zalathar
    Zalathar committed May 31, 2024
    Configuration menu
    Copy the full SHA
    feb8f3c View commit details
    Browse the repository at this point in the history

  4. Remove unused rust-demangler support from compiletest

    @Zalathar
    Zalathar committed May 31, 2024
    Configuration menu
    Copy the full SHA
    54b6849 View commit details
    Browse the repository at this point in the history