-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject CVarArgs
in parse_ty_for_where_clause
#125863
Reject CVarArgs
in parse_ty_for_where_clause
#125863
Conversation
r=me when green |
238f6e3
to
32e29d5
Compare
32e29d5
to
8938609
Compare
Ah, I forgot to mention that we're technically regressing stable code like The MBE example I gave above is also unlikely to occur in practice but the chances are way higher (ppls' DSLs are crazy sometimes, cc #115785). @bors r=compiler-errors |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f67a1ac): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -3.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 667.702s -> 668.08s (0.06%) |
Fixes #125847. This regressed in #77035 where the
parse_ty
insideparse_ty_where_predicate
was replaced with the at the time newparse_ty_for_where_clause
which incorrectly stated it would permit CVarArgs (maybe a copy/paste error).r? parser