Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject CVarArgs in parse_ty_for_where_clause #125863

Merged

Conversation

fmease
Copy link
Member

@fmease fmease commented Jun 1, 2024

Fixes #125847. This regressed in #77035 where the parse_ty inside parse_ty_where_predicate was replaced with the at the time new parse_ty_for_where_clause which incorrectly stated it would permit CVarArgs (maybe a copy/paste error).

r? parser

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 1, 2024
@compiler-errors
Copy link
Member

r=me when green

@fmease fmease force-pushed the rej-CVarArgs-in-parse_ty_for_where_clause branch from 238f6e3 to 32e29d5 Compare June 1, 2024 18:55
@fmease fmease force-pushed the rej-CVarArgs-in-parse_ty_for_where_clause branch from 32e29d5 to 8938609 Compare June 1, 2024 18:57
@fmease
Copy link
Member Author

fmease commented Jun 1, 2024

Ah, I forgot to mention that we're technically regressing stable code like #[cfg(any())] fn f3() where for<> ...: {} here. However, the likelihood that anybody relies on it is astronomically low (it requires a for</*...*/> in front of it because ... can't actually begin a type officially).

The MBE example I gave above is also unlikely to occur in practice but the chances are way higher (ppls' DSLs are crazy sometimes, cc #115785).

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jun 1, 2024

📌 Commit 8938609 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2024
@bors
Copy link
Contributor

bors commented Jun 1, 2024

⌛ Testing commit 8938609 with merge f67a1ac...

@bors
Copy link
Contributor

bors commented Jun 1, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing f67a1ac to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 1, 2024
@bors bors merged commit f67a1ac into rust-lang:master Jun 1, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Jun 1, 2024
@fmease fmease deleted the rej-CVarArgs-in-parse_ty_for_where_clause branch June 2, 2024 00:11
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f67a1ac): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.7% [-3.7%, -3.7%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.7% [-3.7%, -3.7%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.702s -> 668.08s (0.06%)
Artifact size: 318.95 MiB -> 318.88 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: TyKind::CVarArgs should have been handled elsewhere
5 participants