Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-make: add some basic docs about the test suite's setup #126087

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jun 6, 2024

r? @Kobzol

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jun 6, 2024
tests/run-make/README.md Outdated Show resolved Hide resolved
tests/run-make/README.md Outdated Show resolved Hide resolved
@jieyouxu
Copy link
Member Author

jieyouxu commented Jun 7, 2024

@rustbot review

@jieyouxu jieyouxu removed the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Jun 7, 2024
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, at least now there is some basic documentation about this, for the uninitiated. I left two nits, but otherwise LGTM. This should wait for #126097, ofc.

tests/run-make/README.md Outdated Show resolved Hide resolved
tests/run-make/README.md Show resolved Hide resolved
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to r=me once #126097 gets merged :)

tests/run-make/README.md Outdated Show resolved Hide resolved
tests/run-make/README.md Outdated Show resolved Hide resolved
@Kobzol
Copy link
Contributor

Kobzol commented Jun 8, 2024

#126097 has been merged.

@jieyouxu
Copy link
Member Author

jieyouxu commented Jun 8, 2024

Addressed review comments. I plan to add some more docs on best practices for rmake.rs tests and a high-level overview of the support library in follow-up PR(s). (Still gathering thoughts / sitting on some ideas for those.)

@bors r=@Kobzol

@bors
Copy link
Contributor

bors commented Jun 8, 2024

📌 Commit e7409d2 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2024
@jieyouxu
Copy link
Member Author

jieyouxu commented Jun 8, 2024

@bors rollup

@bors
Copy link
Contributor

bors commented Jun 9, 2024

⌛ Testing commit e7409d2 with merge 13423be...

@bors
Copy link
Contributor

bors commented Jun 9, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 13423be to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 9, 2024
@bors bors merged commit 13423be into rust-lang:master Jun 9, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 9, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (13423be): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -0.4%, secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
-3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-3.0%, 2.1%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 319.87 MiB -> 319.75 MiB (-0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants