Rollup of 5 pull requests #126274
Merged
Rollup of 5 pull requests #126274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of opaque types." This reverts commit 29a630e.
…ltiple-emits, r=jieyouxu Migrate `run-make/multiple-emits` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`
…2, r=petrochenkov Delegation: fix ICE on recursive delegation fixes rust-lang#124347 r? `@petrochenkov`
…oalbini Remove ignore-cross-compile directive from ui/macros/proc_macro All the other proc-macro tests don't have this, presumably this was forgotten when the restriction got lifted as it does test just fine r? `@pietroalbini`
Do not define opaque types when selecting impls fixes rust-lang#126117 r? `@lcnr` for inconsistency with next solver
…r=oli-obk interpret: ensure we check bool/char for validity when they are used in a cast In general, `Scalar::to_bits` is a bit dangerous as it bypasses all type information. We should usually prefer matching on the type and acting according to that. So I also refactored `unary_op` handling of integers to do that. The remaining `to_bits` uses are operations that just fundamentally don't care about the sign (and only work on integers). invalid_char_cast.rs is the key new test, the others already passed before this PR. r? `@oli-obk`
rustbot
added
A-run-make
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 20ba13c38e In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (0c96061): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 677.565s -> 679.328s (0.26%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
run-make/multiple-emitstormake.rs#126186 (Migraterun-make/multiple-emitstormake.rs)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup