Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-producer, multi-consumer channel (mpmc) #126839

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

obeis
Copy link
Contributor

@obeis obeis commented Jun 22, 2024

Closes #125712

Tracking issue: #126840

r? m-ou-se

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 22, 2024
@obeis obeis mentioned this pull request Jun 22, 2024
4 tasks
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@jeffparsons
Copy link
Contributor

This module is not currently exposed publicly

No longer true as of this PR? :)

@rust-log-analyzer

This comment has been minimized.

library/std/src/sync/mod.rs Outdated Show resolved Hide resolved
library/std/src/sync/mpmc/mod.rs Outdated Show resolved Hide resolved
library/std/src/sync/mpmc/mod.rs Outdated Show resolved Hide resolved
library/std/src/sync/mpmc/mod.rs Outdated Show resolved Hide resolved
library/std/src/sync/mpmc/mod.rs Outdated Show resolved Hide resolved
library/std/src/sync/mpmc/mod.rs Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

@obeis
Copy link
Contributor Author

obeis commented Jul 24, 2024

r? @Amanieu

@rustbot rustbot assigned Amanieu and unassigned m-ou-se Jul 24, 2024
@bors
Copy link
Contributor

bors commented Jul 29, 2024

☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2024
@Amanieu
Copy link
Member

Amanieu commented Oct 1, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Oct 1, 2024

📌 Commit 041e76b has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2024
@bors
Copy link
Contributor

bors commented Oct 1, 2024

⌛ Testing commit 041e76b with merge 8dd5cd0...

@bors
Copy link
Contributor

bors commented Oct 1, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 8dd5cd0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 1, 2024
@bors bors merged commit 8dd5cd0 into rust-lang:master Oct 1, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 1, 2024
@obeis obeis deleted the mpmc branch October 1, 2024 17:09
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8dd5cd0): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.3%, 0.3%] 1
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.3%, 0.3%] 1

Max RSS (memory usage)

Results (primary -1.1%, secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)
-1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Cycles

Results (primary -3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-7.5% [-7.5%, -7.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.3% [-7.5%, 0.9%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.847s -> 770.002s (-0.24%)
Artifact size: 341.40 MiB -> 341.49 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an mpmc concurrent queue