Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak FlatPat::new to avoid a temporarily-invalid state #126932

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Tweak FlatPat::new to avoid a temporarily-invalid state #126932

merged 1 commit into from
Jun 25, 2024

Commits on Jun 25, 2024

  1. Tweak FlatPat::new to avoid a temporarily-invalid state 

    It was somewhat confusing that the old constructor would create a `FlatPat` in
a (possibly) non-simplified state, and then simplify its contents in-place.

So instead we now create its fields as local variables, perform simplification,
and then create the struct afterwards.

This doesn't affect correctness, but is less confusing.
    @Zalathar
    Zalathar committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c2f1072 View commit details
    Browse the repository at this point in the history