Disallowed patterns in extern fn declarations. #12715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| match (*i).pat.node { | ||
| ast::PatIdent(_, _, _) => (), | ||
| _ => ccx.tcx.sess.span_err((*i).pat.span, | ||
| "Patterns aren't allowed in foreign function declarations") |
There was a problem hiding this comment.
Errors in rust traditionally start with lower-case letters instead of upper-case letters.
I would also be fine with whitelisting the _ pattern as well, it seems reasonable enough to allow (and it seems you found a few existing cases of it below).
There was a problem hiding this comment.
@alexcrichton corrected the message and whitelisted the _
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10877
There was another PR which attempted to fix this in the parser (#11804) and which was closed due to inactivity.
This PR modifies typeck instead (as suggested in #11804), which indeed seems to be simpler than modifying the parser and allows for a better error message.