rustc: Fix support for LLVM 3.3 #12719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could install LLVM 3.4 from a PPA in travis as rust-ci does with the third party Rust nightlies. LLVM actually has official repositories for Ubuntu: http://llvm.org/apt/ |
|
I may not be doing it correctly, but I am unable to find the 3.4 PPAs |
The llvm.copysign and llvm.round intrinsics weren't added until LLVM 3.4, so if we're on LLVM 3.3 we lower these to calls in libm instead of LLVM intrinsics. This should fix our travis failures.
|
@alexcrichton: I think it needs |
|
Indeed it does! I'm experimenting with something for travis which I hope to put up soon. |
bors
added a commit
that referenced
this pull request
Mar 6, 2014
The llvm.copysign and llvm.round intrinsics weren't added until LLVM 3.4, so if we're on LLVM 3.3 we lower these to calls in libm instead of LLVM intrinsics. This should fix our travis failures.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
… r=jonas-schievink Remove unnecessary unsafe from format_args expansion
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 17, 2024
…18, r=xFrednet Fix website dash replacement Fixes: rust-lang#12718 changelog: Made clippy lints website search replace all occurrences of dashes with underscores instead of only the first one. This is in order to allow the user to search for lints with more than two words using dahses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The llvm.copysign and llvm.round intrinsics weren't added until LLVM 3.4, so if
we're on LLVM 3.3 we lower these to calls in libm instead of LLVM intrinsics.
This should fix our travis failures.