Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect NDEBUG handling in LLVM bindings #127654

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Fix incorrect NDEBUG handling in LLVM bindings #127654

merged 2 commits into from
Jul 13, 2024

Commits on Jul 12, 2024

  1. Fix incorrect NDEBUG handling in LLVM bindings 

    We currently compile our LLVM bindings using `-DNDEBUG` if
debuginfo for LLVM is disabled. However, `NDEBUG` doesn't have
any relation to debuginfo, it controls whether assertions are
enabled.

Rename the environment variable to `LLVM_ASSERTIONS` and drive
it using the `llvm_assertions` option. Also drop the explicit
`debug(false)` call, as cc already sets this up using the
cargo `DEBUG` environment variable.
    @nikic
    nikic committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    776b0ad View commit details
    Browse the repository at this point in the history

  2. Remove LLVMRustDIBuilderInsertDeclareAtEnd return value 

    The return value changed from an Instruction to a DbgRecord in
LLVM 19. As we don't actually use the result, drop the return
value entirely to support both.
    @nikic
    nikic committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8dfd3a4 View commit details
    Browse the repository at this point in the history