Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize option_get_or_insert_default #129087

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

slanterns
Copy link
Contributor

Closes: #82901.

@rustbot label: +T-libs-api

r? libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 14, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 14, 2024
@apiraino
Copy link
Contributor

apiraino commented Sep 5, 2024

t-compiler probably can be removed

@rustbot label -t-compiler

@apiraino apiraino removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 5, 2024
@coolreader18
Copy link
Contributor

Is there anything blocking this from merging?

@GrigorenkoPV
Copy link
Contributor

Is there anything blocking this from merging?

This PR had been opened before the FCP was completed, but now it has been #82901 (comment) so probably nothing other than someone with the merge rights pressing the button r+ing this.

@slanterns
Copy link
Contributor Author

r? @dtolnay

@rustbot rustbot assigned dtolnay and unassigned joshtriplett Sep 27, 2024
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Sep 27, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 27, 2024

📌 Commit aec9116 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129087 (Stabilize `option_get_or_insert_default`)
 - rust-lang#130435 (Move Apple linker args from `rustc_target` to `rustc_codegen_ssa`)
 - rust-lang#130459 (delete sub build directory "debug" to not delete the change-id file)
 - rust-lang#130873 (rustc_target: Add powerpc64 atomic-related features)
 - rust-lang#130916 (Use `&raw` in the compiler)
 - rust-lang#130917 (Fix error span if arg to `asm!()` is a macro call)
 - rust-lang#130927 (update outdated comments)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e76eb96 into rust-lang:master Sep 27, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
Rollup merge of rust-lang#129087 - slanterns:option_get_or_insert_default, r=dtolnay

Stabilize `option_get_or_insert_default`

Closes: rust-lang#82901.

`@rustbot` label: +T-libs-api

r? libs-api
@slanterns slanterns deleted the option_get_or_insert_default branch September 27, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for Option::get_or_insert_default
8 participants