Rollup of 8 pull requests

[matthiaskrgr]

Successful merges:

• Lint that warns when an elided lifetime ends up being a named lifetime (elided_named_lifetimes) #129207 (Lint that warns when an elided lifetime ends up being a named lifetime)
• Use subtyping for UnsafeFnPointer coercion, too #129288 (Use subtyping for UnsafeFnPointer coercion, too)
• Fixing span manipulation and indentation of the suggestion introduced by #126187 #129405 (Fixing span manipulation and indentation of the suggestion introduced by For E0277 suggest adding Result return type for function when using QuestionMark ? in the body. #126187)
• gitignore: ignore ICE reports regardless of directory #129518 (gitignore: ignore ICE reports regardless of directory)
• Remove redundant flags from lower_ty_common that can be inferred from the HIR #129519 (Remove redundant flags from lower_ty_common that can be inferred from the HIR)
• Removes dead code from the compiler #129544 (Removes dead code from the compiler)
• add back test for stable-const-can-only-call-stable-const #129553 (add back test for stable-const-can-only-call-stable-const)
• Avoid taking reference of &TyKind #129590 (Avoid taking reference of &TyKind)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=8

[bors]

📌 Commit 1bac9b2 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1bac9b2 with merge 751e9ff...

[rust-log-analyzer]

The job dist-aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] git2_curl test:false 0.571
warning: elided lifetime has a name
   --> src/cargo/core/workspace.rs:580:66
    |
580 |     pub fn default_members<'a>(&'a self) -> impl Iterator<Item = &Package> {
    |                            -- lifetime `'a` declared here        ^ this elided lifetime gets resolved as `'a`
    = note: `#[warn(elided_named_lifetimes)]` on by default

[RUSTC-TIMING] git2 test:false 3.813
[RUSTC-TIMING] cargo test:false 65.918
---
   Compiling chalk-recursive v0.98.0
error: elided lifetime has a name
   --> crates/hir-def/src/attr.rs:120:75
    |
120 |     pub fn by_key<'attrs>(&'attrs self, key: &'attrs Symbol) -> AttrQuery<'_> {
    |                   ------ lifetime `'attrs` declared here                  ^^ this elided lifetime gets resolved as `'attrs`
    = note: `-D elided-named-lifetimes` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(elided_named_lifetimes)]`

error: elided lifetime has a name
error: elided lifetime has a name
   --> crates/hir-def/src/attr.rs:597:72
    |
565 | impl<'attr> AttrQuery<'attr> {
    |      ----- lifetime `'attr` declared here
...
597 |     pub fn find_string_value_in_tt(self, key: &'attr Symbol) -> Option<&str> {
    |                                                                        ^ this elided lifetime gets resolved as `'attr`
error: elided lifetime has a name
   --> crates/hir-def/src/body.rs:200:57
    |
197 |     pub fn blocks<'a>(
197 |     pub fn blocks<'a>(
    |                   -- lifetime `'a` declared here
...
200 |     ) -> impl Iterator<Item = (BlockId, Arc<DefMap>)> + '_ {
    |                                                         ^^ this elided lifetime gets resolved as `'a`
[RUSTC-TIMING] chalk_recursive test:false 0.454
[RUSTC-TIMING] rayon_core test:false 1.088
   Compiling ra-ap-rustc_pattern_analysis v0.63.0
[RUSTC-TIMING] ra_ap_rustc_pattern_analysis test:false 0.347

[bors]

💔 Test failed - checks-actions