Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen_ssa: consolidate tied target checks #130308

Merged
merged 2 commits into from
Oct 10, 2024
Merged

codegen_ssa: consolidate tied target checks #130308

merged 2 commits into from
Oct 10, 2024

Commits on Sep 24, 2024

  1. tests: add test for rust-lang#105111 

    Enabling a tied feature should not enable the other feature
automatically. This was fixed by something in rust-lang#128796, probably rust-lang#128221
or rust-lang#128679.
    @davidtwco
    davidtwco committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6edd86d View commit details
    Browse the repository at this point in the history

  2. codegen_ssa: consolidate tied feature checking 

    `rustc_codegen_llvm` and `rustc_codegen_gcc` duplicated logic for
checking if tied target features were partially enabled. This commit
consolidates these checks into `rustc_codegen_ssa` in the
`codegen_fn_attrs` query, which also is run pre-monomorphisation for
each function, which ensures that this check is run for unused functions,
as would be expected.
    @davidtwco
    davidtwco committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    207bc77 View commit details
    Browse the repository at this point in the history