Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: Set the dylib path when building books with rustdoc #130536

Merged
merged 1 commit into from
Sep 23, 2024
Merged

bootstrap: Set the dylib path when building books with rustdoc #130536

merged 1 commit into from
Sep 23, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Sep 18, 2024

The library path is needed when the toolchain has been configured with
[rust] rpath = false. Otherwise, building the reference book will get
an error when it tries to run rustdoc, like:

rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so

@cuviper
bootstrap: Set the dylib path when building books with rustdoc
de4c897 
The library path is needed when the toolchain has been configured with
`[rust] rpath = false`. Otherwise, building the reference book will get
an error when it tries to run rustdoc, like:

    rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so
@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 18, 2024
@cuviper
Copy link
Member Author

cuviper commented Sep 18, 2024

This might be worth a backport too, because this is a regression from #128215.

@rustbot label beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 18, 2024
@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 22, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 22, 2024

📌 Commit de4c897 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 23, 2024
@workingjubilee
Rollup merge of rust-lang#130536 - cuviper:rustbook-dylib-path, r=Mar…
060e4ce 
…k-Simulacrum

bootstrap: Set the dylib path when building books with rustdoc

The library path is needed when the toolchain has been configured with
`[rust] rpath = false`. Otherwise, building the reference book will get
an error when it tries to run rustdoc, like:

    rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so
This was referenced Sep 23, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2024
@bors
Auto merge of rust-lang#130755 - workingjubilee:rollup-zpja9b3, r=wor…
9d6039c 
…kingjubilee

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129201 (std: implement the `random` feature (alternative version))
 - rust-lang#130536 (bootstrap: Set the dylib path when building books with rustdoc)
 - rust-lang#130551 (Fix `break_last_token`.)
 - rust-lang#130657 (Remove x86_64-fuchsia and aarch64-fuchsia target aliases)
 - rust-lang#130721 (Add more test cases for block-no-opening-brace)
 - rust-lang#130736 (Add rustfmt 2024 reformatting to git blame ignore)
 - rust-lang#130746 (readd `@tgross35` and `@joboet` to the review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c58e3cb into rust-lang:master Sep 23, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2024
@rust-timer
Unrolled build for rust-lang#130536
fde0448 
Rollup merge of rust-lang#130536 - cuviper:rustbook-dylib-path, r=Mark-Simulacrum

bootstrap: Set the dylib path when building books with rustdoc

The library path is needed when the toolchain has been configured with
`[rust] rpath = false`. Otherwise, building the reference book will get
an error when it tries to run rustdoc, like:

    rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so
@cuviper cuviper mentioned this pull request Sep 26, 2024
Merged
@cuviper cuviper modified the milestones: 1.83.0, 1.82.0 Sep 26, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 26, 2024
@cuviper cuviper deleted the rustbook-dylib-path branch September 27, 2024 01:16
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130888 - cuviper:beta-next, r=cuviper
1bc109c 
[beta] backports

- Use equality when relating formal and expected type in arg checking rust-lang#129317
- Don't call `extern_crate` when local crate name is the same as a dependency and we have a trait error rust-lang#130275
- bootstrap: Set the dylib path when building books with rustdoc rust-lang#130536

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130888 - cuviper:beta-next, r=cuviper
6a3b69c 
[beta] backports

- Use equality when relating formal and expected type in arg checking rust-lang#129317
- Don't call `extern_crate` when local crate name is the same as a dependency and we have a trait error rust-lang#130275
- bootstrap: Set the dylib path when building books with rustdoc rust-lang#130536

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cuviper @rustbot @Mark-Simulacrum @bors