[Clippy] Get rid of most std match_def_path usage, swap to diagnostic items.
#130553
Conversation
…ostic items instead of paths
…m instead of path
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
O-unix
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
| @@ -416,6 +416,7 @@ impl<T> Vec<T> { | |||
| /// ``` | |||
| #[inline] | |||
| #[rustc_const_stable(feature = "const_vec_new", since = "1.39.0")] | |||
| #[cfg_attr(not(test), rustc_diagnostic_item = "vec_new")] | |||
There was a problem hiding this comment.
I mentioned on Zulip already, but we typically do this by making the item a diagnostic item then checking the method's identifier. That's typically how it's suggested to be done. But regardless this way is fine, and it doesn't need to be blocked on it
There was a problem hiding this comment.
Yeah, I had already implemented all this before talking on Zulip and seeing the idea to check method identifiers. Since there are already diagnostic items on methods, you are correct that this very much shouldn't be blocked on that though.
|
@rustbot author given the discussion in https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Associated.20function.20from.20type.20DefId.20and.20Symbol.3F, since we might be able to drastically cut down on the number of diagnostic items that we need to define |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-author
|
Discussed in another channel; author mentioned that she didn't currently plan on cleaning up the "one million diagnostic items" problem since its own large body of work. Give me a sec, I'll review this as-is. |
rustbot
added
S-waiting-on-review
|
@bors r+ I would like to repeat that it would be very nice if we cleaned this up "the right way" though, in the future; it would mean that clippy would need fewer rustc-based PRs to add new diagnostics, and it would mean the standard library has fewer diagnostic items. |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#128001 (Improve documentation for <integer>::from_str_radix) - rust-lang#130553 ([Clippy] Get rid of most `std` `match_def_path` usage, swap to diagnostic items.) - rust-lang#130554 (`pal::unsupported::process::ExitCode`: use an `u8` instead of a `bool`) - rust-lang#130556 (Mark the `link_cfg` feature as internal) - rust-lang#130558 (Support 128-bit atomics on s390x) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#130553 - GnomedDev:remove-clippy-paths, r=compiler-errors [Clippy] Get rid of most `std` `match_def_path` usage, swap to diagnostic items. Part of rust-lang/rust-clippy#5393. This was going to remove all `std` paths, but `SeekFrom` has issues being cleanly replaced with a diagnostic item as the paths are for variants, which currently cannot be diagnostic items. This also, as a last step, categories the paths to help with future path removals.
…=compiler-errors [Clippy] Remove final std paths for diagnostic item Removes the paths to SeekFrom::Start/Current that were left in rust-lang#130553. This was split off as it involves introducing a utility to check for enum ctors, as both: - enum variants cannot be diagnostic items - even if they could, that wouldn't help because we need to get the enum variant ctor While adding the `is_enum_variant_ctor`, I removed both `is_diagnostic_ctor` and `is_res_diagnostic_ctor` as they are unused and never worked due to the above bullet points.
Rollup merge of rust-lang#130607 - GnomedDev:remove-seekfrom-paths, r=compiler-errors [Clippy] Remove final std paths for diagnostic item Removes the paths to SeekFrom::Start/Current that were left in rust-lang#130553. This was split off as it involves introducing a utility to check for enum ctors, as both: - enum variants cannot be diagnostic items - even if they could, that wouldn't help because we need to get the enum variant ctor While adding the `is_enum_variant_ctor`, I removed both `is_diagnostic_ctor` and `is_res_diagnostic_ctor` as they are unused and never worked due to the above bullet points.
Part of rust-lang/rust-clippy#5393.
This was going to remove all
stdpaths, butSeekFromhas issues being cleanly replaced with a diagnostic item as the paths are for variants, which currently cannot be diagnostic items.This also, as a last step, categories the paths to help with future path removals.