New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utf8Chunks: add link to Utf8Chunk #130845

Merged

bors merged 1 commit into rust-lang:master from RalfJung:utf8chunk

Sep 27, 2024

Member

RalfJung commented Sep 25, 2024

It is currently surprisingly non-trivial to go from the utf8_chunks method to the docs of the valid/invalid methods used in the example. This should help.


          Utf8Chunks: add link to Utf8Chunk

8f1ed9b

rustbot assigned thomcc

Collaborator

rustbot commented Sep 25, 2024

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review T-libs labels

Contributor

tgross35 commented Sep 25, 2024

I was thinking that you can just click on the return value, but realized that is Utf8Chunks and this is linking Utf8Chunk (no s), which you need to get by going to the iterator implementation of Utf8Chunks. So makes sense to shortcut this.

@bors r+ rollup

Contributor

bors commented Sep 25, 2024

📌 Commit 8f1ed9b has been approved by tgross35

It is now in the queue for this repository.

bors added S-waiting-on-bors and removed S-waiting-on-review labels

tgross35 assigned tgross35 and unassigned thomcc

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#130845 - RalfJung:utf8chunk, r=tgross35

a2b96db

Utf8Chunks: add link to Utf8Chunk

It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.

matthiaskrgr mentioned this pull request

Rollup of 5 pull requests #130854

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130854 - matthiaskrgr:rollup-prsu23n, r=matth…

bd2621e

…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#129687 (Implement RFC3137 trim-paths sysroot changes - take 2)
 - rust-lang#129759 (Stabilize `const_refs_to_static`)
 - rust-lang#130329 (Reorder stack spills so that constants come later.)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130846 (Revert Break into the debugger on panic (129019))

r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#130845 - RalfJung:utf8chunk, r=tgross35

31f854f

Utf8Chunks: add link to Utf8Chunk

It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.

matthiaskrgr mentioned this pull request

Rollup of 7 pull requests #130871

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130871 - matthiaskrgr:rollup-2cfpxt7, r=matth…

dd8dd7f

…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130860 (Fix directives for lint-non-snake-case-crate)
 - rust-lang#130861 (Use `mem::offset_of!` for `sockaddr_un.sun_path`)
 - rust-lang#130865 (Use `&raw` in the standard library)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)

r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#130845 - RalfJung:utf8chunk, r=tgross35

f9dbe10

Utf8Chunks: add link to Utf8Chunk

It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.

matthiaskrgr mentioned this pull request

Rollup of 5 pull requests #130876

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130876 - matthiaskrgr:rollup-ntrxdhe, r=matth…

d80c3fe

…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130860 (Fix directives for lint-non-snake-case-crate)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)

r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#130845 - RalfJung:utf8chunk, r=tgross35

41cf64c

Utf8Chunks: add link to Utf8Chunk

It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.

matthiaskrgr mentioned this pull request

Rollup of 6 pull requests #130878

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130878 - matthiaskrgr:rollup-npprq87, r=matth…

0c31763

…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#129687 (Implement RFC3137 trim-paths sysroot changes - take 2)
 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)
 - rust-lang#130873 (rustc_target: Add powerpc64 atomic-related features)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130878 - matthiaskrgr:rollup-npprq87, r=matth…

f44615f

…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#129687 (Implement RFC3137 trim-paths sysroot changes - take 2)
 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)
 - rust-lang#130873 (rustc_target: Add powerpc64 atomic-related features)

r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#130845 - RalfJung:utf8chunk, r=tgross35

886a77b

Utf8Chunks: add link to Utf8Chunk

It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.

matthiaskrgr mentioned this pull request

Rollup of 10 pull requests #130893

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130893 - matthiaskrgr:rollup-u4rpfrm, r=matth…

ea37d7e

…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#129687 (Implement RFC3137 trim-paths sysroot changes - take 2)
 - rust-lang#130517 (Add the library workspace to the suggested rust-analyzer config)
 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130850 (Pass Module Analysis Manager to Standard Instrumentations)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)
 - rust-lang#130873 (rustc_target: Add powerpc64 atomic-related features)
 - rust-lang#130879 (Pass correct HirId to late_bound_vars in diagnostic code)
 - rust-lang#130880 (add missing FIXME(const-hack))

r? `@ghost`
`@rustbot` modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request


          Rollup merge of rust-lang#130845 - RalfJung:utf8chunk, r=tgross35

0f628b2

Utf8Chunks: add link to Utf8Chunk

It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.

workingjubilee mentioned this pull request

Rollup of 11 pull requests #130902

Closed

tgross35 added a commit to tgross35/rust that referenced this pull request


          Rollup merge of rust-lang#130845 - RalfJung:utf8chunk, r=tgross35

59bd2ad

Utf8Chunks: add link to Utf8Chunk

It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.

tgross35 mentioned this pull request

Rollup of 8 pull requests #130903

Closed

GuillaumeGomez mentioned this pull request

Rollup of 11 pull requests #130907

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130907 - GuillaumeGomez:rollup-423r4i4, r=Gui…

58420a0

…llaumeGomez

Rollup of 11 pull requests

Successful merges:

 - rust-lang#130279 (Document subtleties of `ManuallyDrop`)
 - rust-lang#130517 (Add the library workspace to the suggested rust-analyzer config)
 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130850 (Pass Module Analysis Manager to Standard Instrumentations)
 - rust-lang#130861 (Use `mem::offset_of!` for `sockaddr_un.sun_path`)
 - rust-lang#130862 (rustdoc: do not animate :target when user prefers reduced motion)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)
 - rust-lang#130879 (Pass correct HirId to late_bound_vars in diagnostic code)
 - rust-lang#130880 (add missing FIXME(const-hack))

r? `@ghost`
`@rustbot` modify labels: rollup

bors merged commit e650546 into rust-lang:master

6 checks passed

rustbot added this to the 1.83.0 milestone

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request


          Unrolled build for rust-lang#130845

5d88094

Rollup merge of rust-lang#130845 - RalfJung:utf8chunk, r=tgross35

Utf8Chunks: add link to Utf8Chunk

It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.

RalfJung deleted the utf8chunk branch

September 27, 2024 07:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors T-libs